Detect error APDUs during navigation to have proper error APDUs exceptions instead of timeouts#265
Merged
fbeutin-ledger merged 1 commit intomasterfrom Jan 30, 2026
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #265 +/- ##
==========================================
+ Coverage 77.69% 77.81% +0.12%
==========================================
Files 36 36
Lines 2170 2182 +12
==========================================
+ Hits 1686 1698 +12
Misses 484 484
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This pull request enhances error handling in the Speculos backend by detecting APDU errors during navigation operations, preventing test timeouts when applications return error responses. Instead of waiting indefinitely for screen changes that will never occur, the code now checks for async APDU errors proactively and raises exceptions immediately.
Changes:
- Added
_check_async_error()method to detect and raise APDU errors early during async operations - Modified
wait_for_screen_change()to check for async errors in each iteration before sending ticks - Updated
exchange_async_raw()to track pending async responses for error detection - Added comprehensive test coverage for the new error detection behavior
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/ragger/backend/speculos.py | Implements async error detection mechanism with new _pending_async_response attribute, _check_async_error() method, and integration into navigation loops |
| tests/functional/backend/test_speculos.py | Adds test verifying that errors are raised during navigation rather than at context exit |
| CHANGELOG.md | Documents the feature addition in version 1.42.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…tions instead of timeouts
fbeutin-ledger
force-pushed
the
fbe/raise_during_navigation
branch
from
cb060cc to
2e2661d
Compare
|
cedelavergne-ledger
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.