refactor: change fetching check runs module to not depend on inputs#49
Draft
Ben Challis (ben-challis) wants to merge 1 commit intomainfrom
Draft
refactor: change fetching check runs module to not depend on inputs#49Ben Challis (ben-challis) wants to merge 1 commit intomainfrom
Ben Challis (ben-challis) wants to merge 1 commit intomainfrom
Conversation
Ben Challis (ben-challis)
force-pushed
the
refactor-check-run-fetcher
branch
from
097ca84 to
8e9552d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inputs needs refactoring to be 1. owned by the main loop, 2. a factory driven approach so that catching validation errors can be graceful. Removing reliance on inputs from fetching check results is a step towards that.