This repository was archived by the owner on Aug 2, 2019. It is now read-only.
fix for empty filters; fix for sorting of fields #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added a code to check whether the user has suplied filters and if not reshape the looker api url so it is correctly signed added test case for queries with no filters
per looker api the fields order will determine the order of returned fields
…nd above only allows TLSv1.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 minor fixes.
commit bb7569e checks whether there were filters set in the query and if not doesn't add them to the query url. the problem is that when looker signs the url it sorts the empty params on the top of the list so their url looks like: http://host:port/resource/?&fields=.... while the url that looker-python-sdk produces looks like http://host:port/resource?fields=...&&
commit 1bbfa0d removes the field sorting. Looker API docs are a bit confusing on this but the Ruby SDK is more specific: The fields order determines the resulting data order