-
Notifications
You must be signed in to change notification settings - Fork 22
Add guide options to vis_grid_clus() #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lahuuki
wants to merge
17
commits into
devel
Choose a base branch
from
vis_grid_clus_one_legend
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
In the next few weeks let's try to find some time to resolve this one @lahuuki. I think that what was pending were some changes to make this work also on the shiny apps (aka |
Member
|
@lahuuki we should revisit this PR, particularly with the changes we would need to implement on the shiny app side of things. Were the other parts up to date? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add options for guides in
vis_grid_clus(guides = c("all", "last", "none")). These options help make multi-sample plots less cluttered.All is default - plots legends for ALL samples
vis_gene_clus_all.pdf
lastplots the guide for only the last plotvis_gene_clus_guide_last.pdf
noneplots none of the guides, but exports a guide on the next page of the pdf file, helpful for placing by hand when building polished plotsvis_gene_clus_guide_none.pdf
Other changes:
...withtitle_suffixarg that is better defined and prevents unexpected behavior in vis_*() funcitonssort_clust = FALSE