Fix ins/mark markdown rendering without crashing previews#9
Draft
Fix ins/mark markdown rendering without crashing previews#9
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
remark-ins/remark-markcaused the comment preview rendering to break in this environment, so a safer in-tree transformation was required to restore previews.++insert++and==mark==inline syntaxes.Description
remark-insandremark-markpackages and updated the lockfile andpackage.jsonto reflect their removal.rehypeInsMarkinsrc/components/comments/comment-markdown.tsxthat turns++...++into<ins>and==...==into<mark>at the HAST stage.rehypeInsMarkin therehypePluginslist used byReactMarkdownand ensuredins/markare allowed in the custom sanitize schema.remarkGfm,remarkMath,remarkSupersub,remarkDirective, andremarkEmoji) and left theMarkdownErrorBoundaryfallback to avoid full-page crashes.Testing
bun remove remark-ins remark-mark, which completed successfully and updated the lockfile. (success)bun dev(launchingnext dev) and requestedGET /comments/guide, which returned200 OKindicating the page served. (success)/comments/guideand produced the screenshot artifactartifacts/markdown-ins-mark-fixed.png, confirming the comment preview renders; unrelated TLS/font download warnings and an AuthMissingSecreterror causingGET /api/auth/session500 were observed but did not block the preview render. (warnings present, page render succeeded)Codex Task