add info.live=True states to douyin/live.py which ensure timestre in filename.#624
Open
a67878813 wants to merge 8 commits intoLifeActor:masterfrom
Open
add info.live=True states to douyin/live.py which ensure timestre in filename.#624a67878813 wants to merge 8 commits intoLifeActor:masterfrom
a67878813 wants to merge 8 commits intoLifeActor:masterfrom
Conversation
SeaHOH
reviewed
Jun 29, 2023
|
|
||
| videoloop_label = match1( | ||
| html, '\$ROOM\.room_biz_all\s*=\s*\{\"videoLoop\":(\d+)') | ||
| assert not (videoloop_label == '1') , 'Douyu重播' |
Collaborator
There was a problem hiding this comment.
这里不应退出，我认为可以选择以下两个方案之一：
-
如果可以，则重定向到
douyu/video(不确定是否有对应的视频)。 -
修改
info = MediaInfo('斗鱼重播 (DouyuTV)')，后面的title也作相应修改。
Contributor
Author
There was a problem hiding this comment.
1.即使重定向到douyu/video，估计不会暴露视频地址。
2.info补全后，返回的MediaInfo结构需添加额外flag，需要增加命令行参数才能做出“给定直播地址，存在回放标识，停止录制”功能。这样可接受吗？
7x24全开时，开回放的直播间很麻烦。(回放-直播)的ts流结构不正常。
Collaborator
There was a problem hiding this comment.
ykdl 自带的 cykdl 事实上只是一个范例，ykdl 本身定位是作为库来调用的，需要保持功能完整没有无故缺失。如果有更复杂的要求，可以另行编写脚本调用 ykdl 并处理返回数据，这里的数据原则上尽可能遵循 AS-IS，如何处理则在于用户。你面临的使用场景即是后者，而不是去更改 ykdl 本身。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add info.live=True states to douyin/live.py which ensure timestre in filename.