edited widget modules for css efficiency by captain-nemo-10994 · Pull Request #59 · LightSys/centrallix

captain-nemo-10994 · 2022-06-17T17:31:13Z

How does this look?

gbeeley

Change needed in class naming. Thanks! :)

gbeeley · 2022-06-17T21:42:29Z

centrallix/htmlgen/htdrv_map.c


 	/** HTML body <DIV> element to be used by the OpenLayers map. **/
-	htrAddBodyItem_va(s, "<DIV ID=\"map%POSbase\">\n", id);
+	htrAddBodyItem_va(s, "<DIV ID=\"map%POSbase\" class=div.wmap>\n", id);


This should be class="wmap".

…anges are both welcome and desired.

gbeeley

Thanks! See comments for changes needed.

gbeeley · 2022-07-11T22:35:28Z

centrallix/htmlgen/htdrv_datetime.c


+int htdtSetup(pHtSession s)
+	{
+	htrAddStylesheetItem_va(s,"\t.absHidInh { OVERFLOW: hidden; POSITION:absolute; VISIBILITY:inherit;}\n");


Make sure that all classes begin with the prefix for the widget in question. In this case "dt". Also, it doesn't look like this class actually gets applied to any datetime widget DIVs, but it is necessary to replace the original CSS. Multiple classes can be applied to an HTML element by separating the classes with a space, e.g. <div class="dtBtn dtAhi"></div> or similar.

I do see this issue in other widgets as well, so I'll go ahead and turn the PR back over to you for updates.

gbeeley

Getting closer. :) Once the items addressed here are fixed, the next step is to test this not just with the samples/ files but also with Kardia itself. I'll want to log into your VM and use your running copy of Centrallix to test this out.

gbeeley · 2022-07-12T21:24:19Z

centrallix/htmlgen/htdrv_dropdown.c

-    htrAddBodyItem_va(s,"<DIV ID=\"dd%POScon1\"></DIV>\n",id);
-    htrAddBodyItem_va(s,"<DIV ID=\"dd%POScon2\"></DIV>\n",id);
+    htrAddBodyItem_va(s,"<DIV ID=\"dd%POScon1\" class=\"ddCon1\"></DIV>\n",id);
+    htrAddBodyItem_va(s,"<DIV ID=\"dd%POScon2\" class=\"ddCon2\"></DIV>\n",id);


It looks like the ddAbsHid class got left off of these.

gbeeley · 2022-07-12T21:30:06Z

centrallix/htmlgen/htdrv_menu.c


+int htmenuSetup(pHtSession s)
+	{
+	htrAddStylesheetItem_va(s,"\t.zeroLeftTop { LEFT:0px; TOP:0px; }\n");


Make sure this class uses the module prefix.

gbeeley · 2022-07-12T21:31:19Z

centrallix/htmlgen/htdrv_menu.c

+//	    else
+//		htrAddBodyItem(s,"<tr><td background=\"/sys/images/white_1x1.png\"><img src=\"/sys/images/trans_1.gif\" height=\"1\" width=\"1\"></td><td>");
+//	    }
+//	else


The Dom0NS branch of this IF statement can be deleted entirely (not just commented out). We can always go back to prior git revisions to retrieve the code if we ever need it for some reason.

centrallix/htmlgen/htdrv_page.c

centrallix/htmlgen/htdrv_pane.c

gbeeley · 2022-07-12T21:42:23Z

centrallix/htmlgen/htdrv_tab.c


 	    /** Add DIV section for the tabpage. **/
-	    htrAddBodyItem_va(s,"<div id=\"tc%POSpane%POS\" style=\"POSITION:absolute; VISIBILITY:%STR&CSSVAL; LEFT:0px; TOP:0px; WIDTH:%POSpx; Z-INDEX:%POS;\">\n",
+	    htrAddBodyItem_va(s,"<div id=\"tc%POSpane%POS\" class=\"tcPane\" style=\"POSITION:absolute; VISIBILITY:%STR&CSSVAL; LEFT:0px; TOP:0px; WIDTH:%POSpx; Z-INDEX:%POS;\">\n",


We should have a CSS rule to to with tcPane. The static inline styles can be included in that.

gbeeley · 2022-07-12T21:42:36Z

centrallix/htmlgen/htdrv_tab.c


 	/** h-2 and w-2 because w3c dom borders add to actual width **/
-	htrAddBodyItem_va(s,"<div id=\"tc%POSbase\" style=\"position:absolute; overflow:hidden; height:%POSpx; width:%POSpx; left:%INTpx; top:%INTpx; z-index:%POS; border-width: 1px; border-style:%STR&CSSVAL; border-color: %STR&CSSVAL; border-radius:%POSpx %POSpx %POSpx %POSpx; box-shadow: %DBLpx %DBLpx %POSpx %STR&CSSVAL;\">\n",
+	htrAddBodyItem_va(s,"<div id=\"tc%POSbase\" class=\"tcBase\" style=\"position:absolute; overflow:hidden; height:%POSpx; width:%POSpx; left:%INTpx; top:%INTpx; z-index:%POS; border-width: 1px; border-style:%STR&CSSVAL; border-color: %STR&CSSVAL; border-radius:%POSpx %POSpx %POSpx %POSpx; box-shadow: %DBLpx %DBLpx %POSpx %STR&CSSVAL;\">\n",


Static inline styles can go up in the CSS rule.

gbeeley

Couple more items here. Thanks!

gbeeley · 2022-07-12T23:00:40Z

centrallix/htmlgen/htdrv_dropdown.c

-    htrAddBodyItem_va(s,"<DIV ID=\"dd%POScon1\"></DIV>\n",id);
-    htrAddBodyItem_va(s,"<DIV ID=\"dd%POScon2\"></DIV>\n",id);
+    htrAddBodyItem_va(s,"<DIV ID=\"dd%POScon1\" class=\"ddCon1 ddAbsHid\"></DIV>\n",id);
+    htrAddBodyItem_va(s,"<DIV ID=\"dd%POScon2\" class=\"ddCon2 ddAbsHid\"></DIV>\n",id);


Looks like a typo here - ddAbsHid vs ddHidAbs.

gbeeley · 2022-07-12T23:01:45Z

centrallix/htmlgen/htdrv_menu.c

-	    htrAddBodyItem_va(s,"</table></div><div id=\"mn%POShigh\"></div></body></div>", id);
-	else
-	    htrAddBodyItem_va(s,"</table></div><div id=\"mn%POShigh\"></div></div>\n", id);
+	htrAddBodyItem_va(s,"</table></div><div id=\"mn%POShigh\" class=\"menuHigh zeroLeftTop\"></div></div>\n", id);


Looks like zeroLeftTop didn't get updated here.

gbeeley

Thanks! Looks good.

Sam Adams added 2 commits June 17, 2022 11:28

edited htdrv_map.c for css efficiency

350e59c

fixed a typo

1a07317

gbeeley requested changes Jun 17, 2022

View reviewed changes

Sam Adams added 2 commits July 8, 2022 13:04

The roughest draft of the CSS Efficiency Redo. Recommendations for ch…

d89838a

…anges are both welcome and desired.

Removed unneccessary file

26ef763

captain-nemo-10994 requested a review from gbeeley July 8, 2022 19:15

Tweaked map widget

12f9449

gbeeley changed the title ~~edited htdrv_map.c for css efficiency~~ edited widget modules for css efficiency Jul 8, 2022

gbeeley requested changes Jul 11, 2022

View reviewed changes

Renamed and applied CSS classes

b1dcaf8

captain-nemo-10994 requested a review from gbeeley July 11, 2022 23:23

gbeeley requested changes Jul 12, 2022

View reviewed changes

Changes requested for PR

ea9d9ae

captain-nemo-10994 requested a review from gbeeley July 12, 2022 22:16

gbeeley requested changes Jul 12, 2022

View reviewed changes

Changes requested for PR (part 2)

93e90b5

captain-nemo-10994 requested a review from gbeeley July 12, 2022 23:09

Fixed dropdown borders and datetime font color

2907a7b

gbeeley approved these changes Jul 28, 2022

View reviewed changes

Conversation

captain-nemo-10994 commented Jun 17, 2022

Uh oh!

gbeeley left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gbeeley left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gbeeley left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gbeeley left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gbeeley left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants