Implement Responsive Client-Side Autoscaling#85
Closed
Lightning11wins wants to merge 105 commits intomasterfrom
Closed
Implement Responsive Client-Side Autoscaling#85Lightning11wins wants to merge 105 commits intomasterfrom
Lightning11wins wants to merge 105 commits intomasterfrom
Conversation
…with an unknown type.
…yout, button, editbox, html, image, label, scrollpane, textbutton, & treeview.
Fixes components, dropdowns, and images. Renames flex variables to be more clear. Send parent_w and parent_h to client.
Add tab-height support to apos.c. Add design support to apos.c. Add IsDesign to the WgtrClientInfo struct. Fix spelling mistakes. Clean up.
Add an error message when cxsecVerifySymbol_n() fails. Improve an existing error message when htr_internal_WriteWgtrProperty() fails to write a property of an unknown type. Set Centrallix event listener to be explicitly non-passive, fixing a console error when later code assumes that calling preventDefault() is allowed.
Fix a bug in qprintf() that caused % and & characters inside conditional printing areas to always print, regardless of the condition. Improve documentation for qpfPrintf_va_internal() and qpf_grow_fn_t(). Clean up.
Add shortcut functions: ht_flex_x(), ht_flex_y(), ht_flex_w(), ht_flex_h(). Rename fl_scale_x (was total_fl_x). Rename fl_scale_y (was total_fl_y). Rename fl_scale_w (was total_fl_w). Rename fl_scale_h (was total_fl_h). Rename fl_parent_w (was parent_w). Rename fl_parent_h (was parent_h). Remove ht_flex_format_all and ht_flex_all(). Improve usage of new feature in previously updated widgets. Fix spelling mistakes. Clean up.
Clean up some apps.
Add Math.clamp() and Math.isBetween(). Add getParentSize(), getParentW(), and getParentH(). Refactor getRelativeX/Y/W/H() to call the new getRelative(). Refactor setRelativeX/Y/W/H() to call the new setRelative(). Add fast_setRelativeX/Y(). Add setResponsiveX/Y/W/H() using a new shared setResponsive(). Add responsiveness to moveTo() with the new functions. Fix style guide mistakes. Clean up.
Add support for more edge cases with undefined values to wgtrGetServerProperty(). Add the Log action (and docs). Add the ReloadPage action (and docs). Improve documentation for the Alert widget.
Add htr_action_point() to ht_render.js to handle the point action responsively. Refactor pane and window widgets to use the htr_action_point(). Improve documentation and code clarity for htutil_point(). Improve documentation for the point action.
Update al_reflow() to create responsive CSS using the setResponsive() functions. Improve documentation for al_childresize(). Optimize and clean up inefficient code.
Rewrite C & JS code to use responsive styling. Fix a bug that allowed multiple tabs to be selected at once. Fix spelling errors. Clean up.
Add tab_w and tab_h parameters to tab_features.app to fix broken left and right tab locations. Remove unnecessary button widget from autoscale_test.app.
…uced by disabling clipping CSS by default).
Add dragging cursor styles for window widgets. Add cursor styles for the checkbox, radiobutton, scrollpane, treeview, and window widgets. Update existing cursor styles for the button, datetime, dropdown, imagebutton, tab, and textbutton widgets. Add the .dt_dropdown CSS class to make styling the datetime dropdown easier. Update table columns to use col-resize instead of move. Clean up cursor CSS styles to follow consistent code styling.
…atives. Rewrite getters and setters in the ClipObject polyfill to replace __defineGetter__() and __defineSetter__(). Rewrite getters in the datetime, dropdown, and radiobutton widgets to replace __defineGetter__(). Rewrite pg_area() constructor to replace __defineGetter__(). Define a base when parsing relative properties to fix edge cases. Remove unused debug setters in the table widget. Remove unused debug code.
…aster. Replace calls to fast_setRelativeX/Y() with calls to setRelativeX/Y().
Remove obsolete workaround code. Remove a completed todo. Improve a comment.
|
Too many files changed for review. ( |
Lightning11wins
changed the title
Fix windows failing to release when the mouseup event comes from outside the web page. Update responsive event listener to use a pattern more similar to other resize code. Add .titlebar to window object. Add global wn_windows array that stores all windows.
This was referenced Mar 4, 2026
Contributor
Author
|
Replaced by #90. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After much struggle, I think I've fixed the line endings issue, so I'm ready to restart the review with Greptile. The below PR description is very similar to #84, is now closed.
GitHub Relationships:
This PR includes several
TODOs:TODOs for Israel to handle after Update Duplicate Detection #77 is merged intomaster.TODOs for Greg (although other reviewers are welcome to handle these if they have the requisite knowledge), in the following files:ht_render.c,htdrv_page.c,htdrv_tab.c, andhtdrv_table.c.There are several known issues with this code:
widget/pane: resize action (testapps/kardia/modules/payroll/pay_form.app)widget/image: offset & scale actions (not used anywhere)widget/objcanvas: add_osrc_object()ht_get_parent_w/h__INTERNAL()&wgtrGetContainerWidth/Height()should be merged.ht_get_parent_h__INTERNAL()(mine) gives a height 2px taller.