Skip to content

Conversation

@kiatng
Copy link
Contributor

@kiatng kiatng commented Nov 11, 2025

Summary

Magic is deprecated, this PR migrates it to pixi.

Testing

  • Reviewed all changes for accuracy
  • Verified markdown renders correctly
  • Ensured no broken links

- Fix grammar: "best practice" → "best practices"
- Hyphenate compound adjectives: "production-ready", "open-source"
- Add missing punctuation and Oxford commas
- Improve phrasing and readability throughout
- Add missing imports to UDP server example
- Fix incorrect file reference: LICENSE.txt → LICENSE
- Capitalize HTML consistently
- Replace double hyphen with em dash
- Split comma splice sentences
- Add articles and prepositions where needed
@kiatng kiatng changed the title docs: improve README grammar, clarity, and consistency Migrate to pixi Nov 11, 2025
@josiahls

This comment has been minimized.

@kiatng kiatng force-pushed the docs/readme-grammar-improvements branch from 0321408 to 9c26ef9 Compare November 25, 2025 06:58
@kiatng
Copy link
Contributor Author

kiatng commented Nov 25, 2025

I renamed mojoproject.toml to pixi.toml. pixi.lock exists

@saviorand
Copy link
Collaborator

Looks good, merging now. @kiatng thank you for the contribution!

@kiatng
Copy link
Contributor Author

kiatng commented Nov 27, 2025

I missed magic in CI/CD causing the workflow to fail. Please run it again.

@saviorand
Copy link
Collaborator

@kiatng looks like there's some issue with the tests. I can look into it tomorrow or let me know if you get to it sooner

@saviorand
Copy link
Collaborator

@kiatng I've merged some complementary changes in #270 , they now need to be integrated into your branch for us to be able to merge. Could you resolve the conflicts or give me permissions to push to your fork so I can do it? Either way works for me.

@kiatng kiatng force-pushed the docs/readme-grammar-improvements branch 2 times, most recently from 6c62cb4 to 6bf5a93 Compare November 30, 2025 08:00
@kiatng kiatng force-pushed the docs/readme-grammar-improvements branch from 6bf5a93 to 75b667b Compare November 30, 2025 08:11
@saviorand
Copy link
Collaborator

I think the issues are resolved, the docker image step fails in forks, that's normal.
Merging. Thanks again

@saviorand saviorand merged commit 4983fa2 into Lightbug-HQ:main Nov 30, 2025
3 of 4 checks passed
@kiatng kiatng deleted the docs/readme-grammar-improvements branch December 1, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants