Skip to content

support revision/branches and transformation can return None to skip … #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mpeex wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

support revision/branches and transformation can return None to skip … #769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc50880
support revision/branches and transformation can return None to skip …
mpeex Dec 8, 2025
c2d45bc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 8, 2025
e751699
Merge branch 'main' into main
bhimrazy Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/litdata/streaming/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,10 +464,12 @@ def __getitem__(self, index: ChunkedIndex | int | slice) -> Any:
if isinstance(self.transform, list):
for transform_fn in self.transform:
item = transform_fn(item)
if item is None:
break
else:
item = self.transform(item)

return item
return item if item else self.__next__()
Copy link
Collaborator

@deependujha deependujha Dec 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes more sense to have this in __next__ method, and not in __getitem__.

Copy link
Author

@mpeex mpeex Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the suggestion


def __next__(self) -> Any:
# check if we have reached the end of the dataset (i.e., all the chunks have been processed)
Expand Down
6 changes: 4 additions & 2 deletions src/litdata/streaming/downloader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,11 +591,13 @@ def download_file(self, remote_filepath: str, local_filepath: str) -> None:
FileLock(local_filepath + ".lock", timeout=0),
tempfile.TemporaryDirectory() as tmpdir,
):
_, _, _, repo_org, repo_name, path = remote_filepath.split("/", 5)
repo_id = f"{repo_org}/{repo_name}"
_, _, _, repo_org, repo_name_revision, path = remote_filepath.split("/", 5)
splits = repo_name_revision.split("@", 2)
repo_id = f"{repo_org}/{splits[0]}"
downloaded_path = hf_hub_download(
repo_id,
path,
revision=splits[1] if len(splits) == 2 else None,
cache_dir=tmpdir,
repo_type="dataset",
**self._storage_options,
Expand Down