Draft
Conversation
- Replace mwmatching crate with internal Blossom algorithm (matching.rs) - Remove bincode dep; compute tx size natively via wire-format calculation - Align pair_fits_transaction_size with create_smart_transaction path - Add 32-byte safety margin to transaction size check - Use HashSet for O(1) proof-node overlap instead of linear scan - Eliminate instruction clones via Option::take() - Sort state nullifies by leaf_index before pairing for better overlap - Add pairs_only mode to BuildTransactionBatchConfig for fullness-based foresting - Add merkle_tree field to StateNullifyInstruction for future multi-tree grouping - Remove redundant EmptyProofAccounts error (subsumed by InvalidProofAccountsLength) - Fix stale "30 seconds" comment (actual timeout is 15s) - Add unit tests for pair_state_nullify_batches with realistic fixtures
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Enhanced the transaction building process in `tx_builder.rs` to support paired nullify_2 instructions, improving efficiency. - Updated the instruction batching logic to separate address updates from state nullifications, allowing for better transaction management. - Introduced a new method for estimating transaction sizes without cloning instructions, optimizing performance. - Modified the nullify_2 instruction validation to streamline input checks and ensure proper proof account lengths. - Improved test coverage for nullify_2 functionality, including tests for paired transactions and validation scenarios. - Removed redundant validation functions and adjusted error handling for clarity and consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.