Skip to content

docs: add CLAUDE.md and clean up kora-light-client#2348

Open
tilo-14 wants to merge 3 commits intomainfrom
tilo/kora-light-client-docs
Open

docs: add CLAUDE.md and clean up kora-light-client#2348
tilo-14 wants to merge 3 commits intomainfrom
tilo/kora-light-client-docs

Conversation

@tilo-14
Copy link
Member

@tilo-14 tilo-14 commented Mar 17, 2026

Summary

  • Add comprehensive CLAUDE.md documentation for kora-light-client following the repo's DOCS.md guidelines (integration workflow, packed accounts scheme, API reference, types, constants, compute budget guidance, compatibility notes)
  • Remove dead code: NUM_MAX_POOL_ACCOUNTS, TOKEN_COMPRESSED_ACCOUNT_DISCRIMINATOR constants and unused hex dev-dependency
  • Deduplicate DEFAULT_MAX_TOP_UP constant from 4 builder files into program_ids.rs
  • Add missing test coverage for delegate paths and combined wrap+decompress batch orchestration

Test plan

  • cd kora-light-client && cargo test — 51 tests pass (43 unit + 8 golden bytes)
  • cd kora-light-client && cargo clippy — no warnings
  • CLAUDE.md constants table matches program_ids.rs
  • CLAUDE.md line counts match actual source files

Open with Devin

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 17, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (17)
  • kora-light-client/CLAUDE.md is excluded by none and included by none
  • kora-light-client/Cargo.lock is excluded by !**/*.lock and included by none
  • kora-light-client/Cargo.toml is excluded by none and included by none
  • kora-light-client/src/account_select.rs is excluded by none and included by none
  • kora-light-client/src/create_ata.rs is excluded by none and included by none
  • kora-light-client/src/decompress.rs is excluded by none and included by none
  • kora-light-client/src/error.rs is excluded by none and included by none
  • kora-light-client/src/lib.rs is excluded by none and included by none
  • kora-light-client/src/load_ata.rs is excluded by none and included by none
  • kora-light-client/src/packed_accounts.rs is excluded by none and included by none
  • kora-light-client/src/pda.rs is excluded by none and included by none
  • kora-light-client/src/program_ids.rs is excluded by none and included by none
  • kora-light-client/src/transfer.rs is excluded by none and included by none
  • kora-light-client/src/types.rs is excluded by none and included by none
  • kora-light-client/src/unwrap.rs is excluded by none and included by none
  • kora-light-client/src/wrap.rs is excluded by none and included by none
  • kora-light-client/tests/golden_bytes.rs is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 833a3478-fff8-4a66-9170-d7cfbea392e8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tilo/kora-light-client-docs
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

Add struct builders (Transfer2, TransferChecked, Decompress, Wrap, Unwrap)
matching light-token-client's pattern. Remove internal type leakage from
crate root. Dogfood builders in load_ata.rs. Update CLAUDE.md.

Includes prior work: account selection fixes, packed accounts dedup,
CLAUDE.md documentation.
@tilo-14 tilo-14 force-pushed the tilo/kora-light-client-docs branch from 75962f2 to 850ee62 Compare March 17, 2026 18:47
- Add RentConfig struct + 3 missing fields to CompressionInfo (80→96 bytes)
- Add golden byte test verifying CompressionInfo field layout
- Add PDA tests: find_spl_interface_pda, is_light_token_owner (4 branches)
- Add wrap/unwrap payload tests: compression modes, account indices
- Add large-amount wrap test (near u64::MAX)
- Add wrap/unwrap roundtrip test verifying inverse compression modes
- Fix linter reordering in lib.rs, load_ata.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant