Skip to content

perf: v1 state multi nullify #2349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ananas-block wants to merge 16 commits into
base: main
Choose a base branch
from
Open

perf: v1 state multi nullify #2349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
0caad00
feat: nullify_2 shared proof node and 1-byte discriminator
ananas-block Mar 17, 2026
3b7291d
feat: nullify_dedup instruction for 2-4 nullifications with proof ded…
ananas-block Mar 17, 2026
3365adc
feat: forester dedup integration with min_queue_items threshold, vers…
ananas-block Mar 17, 2026
16b5985
feat: disable v1 state multi-nullify when queue exceeds 10,000 items
ananas-block Mar 18, 2026
513749e
fix: pin time <0.3.46 for Solana platform-tools Cargo 1.84 compatibility
ananas-block Mar 18, 2026
bc36a49
fix: reject non-trailing sentinels in count_from_leaf_indices
ananas-block Mar 18, 2026
8efe3bc
refactor: simplify nullify_state_v1_multi proof dedup encoding
ananas-block Mar 18, 2026
d9087d2
feat: unified forester ALT covering all tree types
ananas-block Mar 18, 2026
f60eda8
feat: add get_queue_leaf_indices
sergeytimoshin Mar 18, 2026
6a8a115
refactor: simplify batched transaction configuration in EpochManager
sergeytimoshin Mar 18, 2026
bd865d5
format
sergeytimoshin Mar 18, 2026
2a2d2da
feat: add presort option for batched transactions to improve deduplic…
sergeytimoshin Mar 18, 2026
b2400ae
feat: update configuration for batching and nullification processes, …
sergeytimoshin Mar 20, 2026
fc3b88c
update dependencies in Cargo.lock
sergeytimoshin Mar 20, 2026
69f2d92
feat: set default work item batch size to 50 in EpochManager configur…
sergeytimoshin Mar 20, 2026
3354c88
fix tests
sergeytimoshin Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,11 @@ go test -run TestLightweight -timeout 15m
End-to-end tests for the off-chain tree maintenance service.

```bash
# Using just (preferred, from forester/ directory):
just -f forester/justfile local # Run e2e test without rebuilding SBF programs
just -f forester/justfile test # Build SBF test deps first, then run e2e test

Comment on lines +180 to +183
Copy link
Contributor

@coderabbitai coderabbitai bot Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix the working-directory mismatch in the Forester just commands.

Line 180 says “from forester/ directory”, but Line 181 and Line 182 use -f forester/justfile, which is a repository-root invocation pattern.

🛠️ Suggested doc fix 
-# Using just (preferred, from forester/ directory):
-just -f forester/justfile local          # Run e2e test without rebuilding SBF programs
-just -f forester/justfile test           # Build SBF test deps first, then run e2e test
+# Using just (preferred, from repository root):
+just -f forester/justfile local          # Run e2e test without rebuilding SBF programs
+just -f forester/justfile test           # Build SBF test deps first, then run e2e test
+
+# If already in forester/ directory:
+just local
+just test
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# Using just (preferred, from forester/ directory):
just -f forester/justfile local # Run e2e test without rebuilding SBF programs
just -f forester/justfile test # Build SBF test deps first, then run e2e test
# Using just (preferred, from repository root):
just -f forester/justfile local # Run e2e test without rebuilding SBF programs
just -f forester/justfile test # Build SBF test deps first, then run e2e test
# If already in forester/ directory:
just local
just test
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@CLAUDE.md` around lines 180 - 183, The documentation header claiming "from
forester/ directory" doesn't match the commands which use "-f forester/justfile"
(repo-root style); either remove the "-f forester/justfile" flags from the two
commands so they run from the forester/ directory (e.g., "just local" and "just
test") or change the header to say "from repository root" to match the existing
"just -f forester/justfile local" and "just -f forester/justfile test"
invocations—update the text and commands around the Forester just examples
accordingly.

# Or directly:
TEST_MODE=local cargo test --package forester e2e_test -- --nocapture
```
Comment on lines +184 to 186
Copy link
Contributor

@coderabbitai coderabbitai bot Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Add a TEST_MODE=devnet Forester e2e example next to local mode.

This section currently documents only local mode; adding devnet keeps the test entrypoints complete for both supported environments.

🧪 Suggested addition 
 # Or directly:
 TEST_MODE=local cargo test --package forester e2e_test -- --nocapture
+TEST_MODE=devnet cargo test --package forester e2e_test -- --nocapture

Based on learnings: "Run E2E tests with TEST_MODE=local cargo test for local validator testing or TEST_MODE=devnet for devnet testing".

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# Or directly:
TEST_MODE=local cargo test --package forester e2e_test -- --nocapture
```
# Or directly:
TEST_MODE=local cargo test --package forester e2e_test -- --nocapture
TEST_MODE=devnet cargo test --package forester e2e_test -- --nocapture
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@CLAUDE.md` around lines 184 - 186, Add a second example invocation for
running Forester e2e tests in devnet mode next to the existing local-mode
example; locate the existing line "TEST_MODE=local cargo test --package forester
e2e_test -- --nocapture" and add a sibling example "TEST_MODE=devnet cargo test
--package forester e2e_test -- --nocapture" (preserving the same flags and
context) so both TEST_MODE=local and TEST_MODE=devnet are documented.


Expand Down
Loading
Loading