chore: js sdk beta fixes

[SwenSchaeferjohann]

No description provided.

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (14)

• js/compressed-token/CHANGELOG.md is excluded by none and included by none
• js/compressed-token/docs/interface.md is excluded by none and included by none
• js/compressed-token/docs/payment-integration.md is excluded by none and included by none
• js/compressed-token/src/index.ts is excluded by none and included by none
• js/compressed-token/src/v3/actions/transfer-interface.ts is excluded by none and included by none
• js/compressed-token/src/v3/instructions/transfer-interface.ts is excluded by none and included by none
• js/compressed-token/src/v3/unified/index.ts is excluded by none and included by none
• js/compressed-token/tests/e2e/input-selection.test.ts is excluded by none and included by none
• js/compressed-token/tests/e2e/multi-cold-inputs-batching.test.ts is excluded by none and included by none
• js/compressed-token/tests/e2e/multi-cold-inputs.test.ts is excluded by none and included by none
• js/compressed-token/tests/e2e/payment-flows.test.ts is excluded by none and included by none
• js/compressed-token/tests/e2e/transfer-interface.test.ts is excluded by none and included by none
• js/compressed-token/tests/e2e/v3-interface-migration.test.ts is excluded by none and included by none
• js/compressed-token/tests/unit/load-transfer-cu.test.ts is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 67173bf2-30d6-4da6-ba7f-27a2880ac7d8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch swen/transferToAccountinterface

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ananas-block]

TransferToAccountOptions / TransferOptions duplication

There are now two names for the same shape:

export interface TransferToAccountOptions extends InterfaceOptions {
    wrap?: boolean;
    programId?: PublicKey;
}
export type TransferOptions = TransferToAccountOptions;

TransferToAccountOptions is only used in three places internally (actions/transfer-interface.ts:172, unified/index.ts:41,388,496). TransferOptions is the older public name and is still wired into instructions/transfer-interface.ts and re-exported from the unified path.

Could we just drop TransferToAccountOptions and the alias, and keep TransferOptions as the one canonical name? That would mean:

• delete the TransferToAccountOptions interface
• delete export type TransferOptions = TransferToAccountOptions
• replace the three internal TransferToAccountOptions references with TransferOptions

No public API change, one fewer type.

[ananas-block]

Dead code: batches.length === 0 guard at actions/transfer-interface.ts:204

if (batches.length === 0) return [[ensureRecipientAtaIx]];

createTransferToAccountInterfaceInstructions never returns an empty array — every non-throwing path returns at least [[CU, transferIx]]. This guard is unreachable and can be deleted.

[ananas-block]

Redundant pre-conversion in transferToAccountInterface (actions/transfer-interface.ts:63)

const amountBigInt = BigInt(amount.toString()); // line 63

The underlying builder (createTransferToAccountInterfaceInstructions in instructions/transfer-interface.ts) always converts amount itself at line 156, so this pre-conversion is a no-op. transferInterface correctly passes amount raw. The fix is to remove the pre-conversion in transferToAccountInterface (and the amountBigInt variable) so both action functions are consistent.

[ananas-block]

Duplicate send loop and source validation in actions/transfer-interface.ts

transferInterface and transferToAccountInterface share two identical blocks verbatim.

Send loop (lines 82–93 and 142–153):

const additionalSigners = dedupeSigner(payer, [owner]);
const { rest: loads, last: transferIxs } = sliceLast(batches);
await Promise.all(loads.map(async ixs => {
    const { blockhash } = await rpc.getLatestBlockhash();
    const tx = buildAndSignTx(ixs, payer, blockhash, additionalSigners);
    return sendAndConfirmTx(rpc, tx, confirmOptions);
}));
const { blockhash } = await rpc.getLatestBlockhash();
const tx = buildAndSignTx(transferIxs, payer, blockhash, additionalSigners);
return sendAndConfirmTx(rpc, tx, confirmOptions);

Source validation (lines 50–61 and 112–123):

const effectiveOwner = options?.owner ?? owner.publicKey;
const expectedSource = getAssociatedTokenAddressInterface(mint, effectiveOwner, false, programId);
if (!source.equals(expectedSource)) {
    throw new Error(`Source mismatch. Expected ${expectedSource.toBase58()}, got ${source.toBase58()}`);
}

Both could be extracted into private helpers, e.g. validateSource(...) and executeBatches(...), reducing the file by ~25 lines and making future changes to the send logic apply in one place.