Fix --quantization fp8-scaled-mm CLI crash#169
Open
garrick99 wants to merge 1 commit intoLightricks:mainfrom
Open
Fix --quantization fp8-scaled-mm CLI crash#169garrick99 wants to merge 1 commit intoLightricks:mainfrom
garrick99 wants to merge 1 commit intoLightricks:mainfrom
Conversation
QuantizationPolicy.fp8_scaled_mm() is a classmethod that takes no arguments, but args.py was passing amax_path to it, causing: TypeError: QuantizationPolicy.fp8_scaled_mm() takes 1 positional argument but 2 were given Match the pattern used by fp8-cast: reject extra arguments and call without args. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #146 —
--quantization fp8-scaled-mmcrashes withTypeError: QuantizationPolicy.fp8_scaled_mm() takes 1 positional argument but 2 were given.Cause
args.pywas passingamax_pathtoQuantizationPolicy.fp8_scaled_mm(), but the classmethod takes no arguments.Fix
Match the pattern already used by
fp8-cast: reject extra arguments and call without args.🤖 Generated with Claude Code