Skip to content

fix: drop redundant rust-analyzer.debug.engine override#60

Merged
failfmi merged 3 commits intodevelopfrom
fix/rust-analyzer-redundant
Apr 30, 2026
Merged

fix: drop redundant rust-analyzer.debug.engine override#60
failfmi merged 3 commits intodevelopfrom
fix/rust-analyzer-redundant

Conversation

@ERoydev
Copy link
Copy Markdown
Collaborator

@ERoydev ERoydev commented Apr 30, 2026

Removes the workspace-level rust-analyzer.debug.engine write — Gimlet's attach flow sets type: 'lldb' directly in its launch config, so the override was dead code and only served to clobber the user's preference.

  • Drop call site, import, and vscodeSettingsManager.js (only consumer)
  • Remove matching row from README workspace-settings table

@ERoydev ERoydev force-pushed the fix/rust-analyzer-redundant branch from 84597ca to 48571fb Compare April 30, 2026 13:20
@ERoydev ERoydev requested review from failfmi and procdump April 30, 2026 13:22
@ERoydev ERoydev marked this pull request as ready for review April 30, 2026 13:22
@failfmi failfmi merged commit c851c0d into develop Apr 30, 2026
1 check passed
@failfmi failfmi deleted the fix/rust-analyzer-redundant branch April 30, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants