Open
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request attempts to upgrade the HtmlRenderer projects to support .NET 10.0, add .NET Framework 4.7.2 support, and update the Visual Studio solution file version. However, there are critical issues with the changes.
- Adds
net10.0andnet472as target frameworks to both HtmlRenderer.csproj and HtmlRenderer.PdfSharp.csproj - Bumps package version from 1.5.1.3 to 1.5.1.4
- Updates Visual Studio solution file to version 18
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Source/HtmlRenderer/HtmlRenderer.csproj | Adds net10.0 and net472 target frameworks and increments version |
| Source/HtmlRenderer.PdfSharp/HtmlRenderer.PdfSharp.csproj | Adds net10.0 and net472 target frameworks and increments version |
| Source/HtmlRenderer.sln | Updates Visual Studio version to 18 (contains typo) |
| .gitignore | Adds exclusion for Visual Studio directory |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Visual Studio Version 16 | ||
| VisualStudioVersion = 16.0.31605.320 | ||
| # Visual Studio Version 18 | ||
| VisualStudioVersion = 18.0.11222.15 d18.0 |
There was a problem hiding this comment.
There appears to be a typo in the VisualStudioVersion. The extra " d18.0" at the end should be removed.
Suggested change
| VisualStudioVersion = 18.0.11222.15 d18.0 | |
| VisualStudioVersion = 18.0.11222.15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.