Skip to content

refactor(match2): match summary to widget #6905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ElectricalBoy wants to merge 15 commits into
base: main
Choose a base branch
from
Open

refactor(match2): match summary to widget #6905

ElectricalBoy wants to merge 15 commits into from

Conversation

@ElectricalBoy
Copy link
Collaborator

@ElectricalBoy ElectricalBoy commented Dec 10, 2025 •
edited
Loading

Summary

This PR:

  • replaces MatchSummary object with MatchSummaryContainer widget
  • adds content switch for bracket reset match

    Lua-Modules/lua/wikis/commons/MatchSummary/Base.lua

    Lines 367 to 372 in 589fc85

    --additional header for when martin adds the the css and buttons for switching between match and reset match
    --if bracketResetMatch then
    --local createHeader = CustomMatchSummary.createHeader or MatchSummary.createDefaultHeader
    --matchSummary:header(createHeader(match, {noScore = true, teamStyle = options.teamStyle}))
    --here martin can add the buttons for switching between match and reset match
    --end
  • adjusts existing match summary entrypoints accordingly

How did you test this change?

fighters:User:ElectricalBoy/Sandbox4 + browser dev tools

@ElectricalBoy ElectricalBoy force-pushed the contentswitch-for-reset-match branch from 3542ee9 to e5f6617 Compare December 10, 2025 03:45
@ElectricalBoy ElectricalBoy marked this pull request as draft December 10, 2025 03:57
@ElectricalBoy ElectricalBoy marked this pull request as ready for review December 10, 2025 04:08
@ElectricalBoy ElectricalBoy added the stylesheets Changes to stylesheets label Dec 10, 2025
@ElectricalBoy ElectricalBoy force-pushed the contentswitch-for-reset-match branch from 10ec29a to 1893b1b Compare December 13, 2025 00:52
hjpalpha
hjpalpha approved these changes Dec 13, 2025
View reviewed changes
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you do a simple perf test for this to see if this has negative impact on perf?

@ElectricalBoy
Copy link
Collaborator Author

ElectricalBoy commented Dec 15, 2025

could you do a simple perf test for this to see if this has negative impact on perf?

https://discord.com/channels/93055209017729024/874304000718172200/1449704505225773137

hjpalpha
hjpalpha approved these changes Dec 15, 2025
View reviewed changes
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ElectricalBoy ElectricalBoy force-pushed the contentswitch-for-reset-match branch from 1893b1b to 1db3a84 Compare January 19, 2026 01:23
Eetwalt
Eetwalt approved these changes Jan 19, 2026
View reviewed changes
Copy link
Collaborator

@Eetwalt Eetwalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but will leave this for Rath to take a look at

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hjpalpha hjpalpha hjpalpha approved these changes

@Eetwalt Eetwalt Eetwalt approved these changes

@Rathoz Rathoz Awaiting requested review from Rathoz

@iMarbot iMarbot Awaiting requested review from iMarbot

Assignees

No one assigned

Labels

c: match2 stylesheets Changes to stylesheets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ElectricalBoy @hjpalpha @Eetwalt