feat(standings): add sdate/edate support to rounds #6923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
for allowing time-based round inputs like in old GTL/STLs |
Collaborator
i think that wasn't wanted for matches/games |
ElectricalBoy
force-pushed
the
standings-sdate-edate
branch
from
16401af to
03da4e5
Compare
Collaborator
Author
https://discord.com/channels/93055209017729024/874304000718172200/1450022705641291857 |
ElectricalBoy
force-pushed
the
standings-sdate-edate
branch
from
03da4e5 to
8da2f42
Compare
hjpalpha
reviewed
Jan 19, 2026
| local matches = Array.parseCommaSeparatedString(roundData.matches) | ||
| local startDate = Logic.isNotEmpty(roundData.sdate) and | ||
| DateExt.readTimestamp(roundData.sdate) or DateExt.defaultTimestamp | ||
| local endDate = Logic.isNotEmpty(roundData.edate) and |
Collaborator
There was a problem hiding this comment.
you candrop the isempty check for this and the one above
readTimestamp returns nil on empty
Collaborator
|
Will leave this be until Rath can take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depends on #6920
This PR adds support for
|sdate=and|edate=params for rounds in standings table.How did you test this change?
dev