Skip to content

Conversation

@ElectricalBoy
Copy link
Collaborator

Summary

This PR:

  • updates MatchFunctions.calculateMatchScore implementations to use currying (da2acf8)
  • fixes spelling errors in parser names (d3cda4c, b07c033)
  • updates type annotations

How did you test this change?

@ElectricalBoy ElectricalBoy added documentation Improvements or additions to documentation c: match2 labels Jan 17, 2026
@Eetwalt Eetwalt requested a review from Copilot January 19, 2026 08:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors match parsing code across multiple wiki modules to improve code consistency and maintainability. The changes include updating calculateMatchScore implementations to use currying via FnUtil.curry, correcting spelling errors in variable names, and improving type annotations throughout the codebase.

Changes:

  • Refactored calculateMatchScore functions to use FnUtil.curry instead of inline anonymous functions
  • Fixed spelling errors in parser class names (e.g., FffMatchFunctions to FfaMatchFunctions)
  • Updated type annotations from generic table[] to specific MGIParsedOpponent[] types

Reviewed changes

Copilot reviewed 65 out of 65 changed files in this pull request and generated no comments.

Show a summary per file
File Description
lua/wikis/*/MatchGroup/Input/Custom.lua Updated calculateMatchScore to use FnUtil.curry and improved type annotations for opponent parameters
lua/wikis/hearthstone/MatchGroup/Input/Custom.lua Fixed spelling of FfaMatchFunctions and added parser class type annotations
lua/wikis/ageofempires/MatchGroup/Input/Custom.lua Fixed spelling of FfaMatchFunctions and added parser class type annotations
lua/wikis/commons/MatchGroup/Input/Starcraft.lua Added parser class type annotations and improved opponent type definitions
lua/wikis/counterstrike/MatchGroup/Input/Custom.lua Added parser class type annotations for all parser interfaces

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@Eetwalt Eetwalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, checked with copilot too and didn't find anything to note so good to go I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: match2 documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants