-
Notifications
You must be signed in to change notification settings - Fork 100
refactor(match2): clean up match parsers #6976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors match parsing code across multiple wiki modules to improve code consistency and maintainability. The changes include updating calculateMatchScore implementations to use currying via FnUtil.curry, correcting spelling errors in variable names, and improving type annotations throughout the codebase.
Changes:
- Refactored
calculateMatchScorefunctions to useFnUtil.curryinstead of inline anonymous functions - Fixed spelling errors in parser class names (e.g.,
FffMatchFunctionstoFfaMatchFunctions) - Updated type annotations from generic
table[]to specificMGIParsedOpponent[]types
Reviewed changes
Copilot reviewed 65 out of 65 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lua/wikis/*/MatchGroup/Input/Custom.lua | Updated calculateMatchScore to use FnUtil.curry and improved type annotations for opponent parameters |
| lua/wikis/hearthstone/MatchGroup/Input/Custom.lua | Fixed spelling of FfaMatchFunctions and added parser class type annotations |
| lua/wikis/ageofempires/MatchGroup/Input/Custom.lua | Fixed spelling of FfaMatchFunctions and added parser class type annotations |
| lua/wikis/commons/MatchGroup/Input/Starcraft.lua | Added parser class type annotations and improved opponent type definitions |
| lua/wikis/counterstrike/MatchGroup/Input/Custom.lua | Added parser class type annotations for all parser interfaces |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Eetwalt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, checked with copilot too and didn't find anything to note so good to go I think
Summary
This PR:
MatchFunctions.calculateMatchScoreimplementations to use currying (da2acf8)How did you test this change?