feat: add dropdown widget #6982
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eetwalt
added
stylesheets
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a reusable dropdown widget component that will be used for an upcoming export feature. The implementation includes styling, Lua widget modules, JavaScript functionality, and comprehensive test coverage.
Changes:
- Added a dropdown widget with toggle button and menu capabilities
- Implemented styling for both light and dark themes with appropriate hover states
- Added three new icon definitions (share, copy, download) for export functionality
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| stylesheets/commons/Dropdown.scss | Defines dropdown widget styles with theme support and interactive states |
| stylesheets/Main.scss | Imports the new dropdown stylesheet |
| lua/wikis/commons/Widget/Basic/DropdownItem.lua | Implements individual dropdown item widget with icon and link support |
| lua/wikis/commons/Widget/Basic/Dropdown.lua | Implements main dropdown wrapper widget with toggle button |
| lua/wikis/commons/Icon/Data.lua | Adds icon definitions for export-related actions |
| lua/spec/dropdown_spec.lua | Provides comprehensive test coverage for dropdown functionality |
| javascript/commons/Dropdown.js | Implements click handling to toggle dropdown visibility |
| javascript/Main.js | Registers the dropdown JavaScript module |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hjpalpha
approved these changes
Jan 19, 2026
Comment on lines
+54
to
+66
| if self.props.link then | ||
| return Div{ | ||
| children = { | ||
| Link{ | ||
| link = self.props.link, | ||
| linktype = self.props.linktype, | ||
| children = {item} | ||
| } | ||
| } | ||
| } | ||
| end | ||
|
|
||
| return item |
Collaborator
There was a problem hiding this comment.
Suggested change
| if self.props.link then | |
| return Div{ | |
| children = { | |
| Link{ | |
| link = self.props.link, | |
| linktype = self.props.linktype, | |
| children = {item} | |
| } | |
| } | |
| } | |
| end | |
| return item | |
| if not self.props.link then | |
| return item | |
| end | |
| return Div{ | |
| children = { | |
| Link{ | |
| link = self.props.link, | |
| linktype = self.props.linktype, | |
| children = {item} | |
| } | |
| } | |
| } |
if you want to reduce indent by 1 :P
Comment on lines
+27
to
+29
| ---@class DropdownItemWidget: Widget | ||
| ---@operator call(DropdownItemWidgetParameters): DropdownItemWidget | ||
| local DropdownItem = Class.new(Widget) |
Collaborator
There was a problem hiding this comment.
Suggested change
| ---@class DropdownItemWidget: Widget | |
| ---@operator call(DropdownItemWidgetParameters): DropdownItemWidget | |
| local DropdownItem = Class.new(Widget) | |
| ---@class DropdownItemWidget: Widget | |
| ---@operator call(DropdownItemWidgetParameters): DropdownItemWidget | |
| ---@field props DropdownItemWidgetParameters | |
| local DropdownItem = Class.new(Widget) |
| } | ||
|
|
||
| return Div{ | ||
| classes = Array.extend({'dropdown-widget'}, self.props.classes or {}), |
Collaborator
There was a problem hiding this comment.
Suggested change
| classes = Array.extend({'dropdown-widget'}, self.props.classes or {}), | |
| classes = Array.extend('dropdown-widget', self.props.classes), |
|
|
||
| ---@class DropdownContainerWidgetParameters | ||
| ---@field button any | ||
| ---@field content Widget|string|table |
Collaborator
There was a problem hiding this comment.
Suggested change
| ---@field content Widget|string|table | |
| ---@field children string|number|Widget|Html|(string|number|Widget|Html)[] |
| toggleButton, | ||
| Div{ | ||
| classes = {'dropdown-widget__menu'}, | ||
| children = self.props.content |
Collaborator
There was a problem hiding this comment.
Suggested change
| children = self.props.content | |
| children = self.props.children |
Comment on lines
+27
to
+28
| ---@return Widget | ||
| function DropdownContainer:render() |
Collaborator
There was a problem hiding this comment.
should this return a widget even if content/children is empty?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a basic dropdown widget. Will be used for an upcoming export feature.
How did you test this change?
https://liquipedia.net/leagueoflegends/User:Eetwalt + css & js