Fix rate#108
Open
JohnRichard4096 wants to merge 7 commits intomainfrom
Open
Conversation
Contributor
|
🧙 Sourcery 已完成对您的拉取请求的审查！ 提示和命令与 Sourcery 互动
自定义您的体验访问您的 仪表盘 以：
获取帮助Original review guide in English🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
你好 - 我已审阅了你的更改 - 这里有一些反馈：
- 在
check_bad_words中，你直接将True传递给jieba.cut，这会降低可读性——考虑使用关键字参数（例如cut_all=True）或切换到jieba.lcut以提高清晰度。 - 角色检查使用了
or并且在发送者角色为真时短路，因此机器人的角色从未实际验证——如果你打算要求两个角色都是 'member'，请使用and。 - 限速器现在默默地丢弃消息而不提供反馈；如果这是有意的，它应该是一个可配置的模式，或者至少进行日志记录以帮助调试。
供AI代理的提示
请处理此代码审查中的评论：
## 总体评论
- 在 `check_bad_words` 中，你直接将 `True` 传递给 `jieba.cut`，这会降低可读性——考虑使用关键字参数（例如 `cut_all=True`）或切换到 `jieba.lcut` 以提高清晰度。
- 角色检查使用了 `or` 并且在发送者角色为真时短路，因此机器人的角色从未实际验证——如果你打算要求两个角色都是 'member'，请使用 `and`。
- 限速器现在默默地丢弃消息而不提供反馈；如果这是有意的，它应该是一个可配置的模式，或者至少进行日志记录以帮助调试。
## 单独评论
### 评论 1
<location> `src/plugins/group/bad_words.py:45-47` </location>
<code_context>
def check_bad_words(
text: str, extra_words: Iterable[str] = [], words: Iterable[str] = BAD_WORDS
) -> bool:
return bool(set(jieba.cut(text, True)) & set(tuple(words) + tuple(extra_words)))
</code_context>
<issue_to_address>
**建议 (代码质量):** 将可变默认参数替换为 `None` ([`default-mutable-arg`](https://docs.sourcery.ai/Reference/Default-Rules/suggestions/default-mutable-arg/))
```suggestion
def check_bad_words(text: str, extra_words: Iterable[str] = None, words: Iterable[str] = BAD_WORDS) -> bool:
if extra_words is None:
extra_words = []
```
</issue_to_address>帮助我更有用！请在每个评论上点击 👍 或 👎，我将使用反馈来改进你的评论。
Original comment in English
Hey there - I've reviewed your changes - here's some feedback:
- In check_bad_words you pass a bare True to jieba.cut, which hurts readability—consider using a keyword argument (e.g. cut_all=True) or switching to jieba.lcut for clarity.
- The role-check uses
orand short-circuits on a truthy sender role so the bot’s role is never actually validated—useandif you intend to require both roles to be 'member'. - The rate limiter now silently drops messages without feedback; if this is intentional it should be a configurable mode or at least logged to help with debugging.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In check_bad_words you pass a bare True to jieba.cut, which hurts readability—consider using a keyword argument (e.g. cut_all=True) or switching to jieba.lcut for clarity.
- The role-check uses `or` and short-circuits on a truthy sender role so the bot’s role is never actually validated—use `and` if you intend to require both roles to be 'member'.
- The rate limiter now silently drops messages without feedback; if this is intentional it should be a configurable mode or at least logged to help with debugging.
## Individual Comments
### Comment 1
<location> `src/plugins/group/bad_words.py:45-47` </location>
<code_context>
def check_bad_words(
text: str, extra_words: Iterable[str] = [], words: Iterable[str] = BAD_WORDS
) -> bool:
return bool(set(jieba.cut(text, True)) & set(tuple(words) + tuple(extra_words)))
</code_context>
<issue_to_address>
**suggestion (code-quality):** Replace mutable default arguments with None ([`default-mutable-arg`](https://docs.sourcery.ai/Reference/Default-Rules/suggestions/default-mutable-arg/))
```suggestion
def check_bad_words(text: str, extra_words: Iterable[str] = None, words: Iterable[str] = BAD_WORDS) -> bool:
if extra_words is None:
extra_words = []
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
45
to
47
| def check_bad_words( | ||
| text: str, extra_words: Iterable[str] = [], words: Iterable[str] = BAD_WORDS | ||
| ) -> bool: |
Contributor
There was a problem hiding this comment.
建议 (代码质量): 将可变默认参数替换为 None (default-mutable-arg)
Suggested change
| def check_bad_words( | |
| text: str, extra_words: Iterable[str] = [], words: Iterable[str] = BAD_WORDS | |
| ) -> bool: | |
| def check_bad_words(text: str, extra_words: Iterable[str] = None, words: Iterable[str] = BAD_WORDS) -> bool: | |
| if extra_words is None: | |
| extra_words = [] |
Original comment in English
suggestion (code-quality): Replace mutable default arguments with None (default-mutable-arg)
Suggested change
| def check_bad_words( | |
| text: str, extra_words: Iterable[str] = [], words: Iterable[str] = BAD_WORDS | |
| ) -> bool: | |
| def check_bad_words(text: str, extra_words: Iterable[str] = None, words: Iterable[str] = BAD_WORDS) -> bool: | |
| if extra_words is None: | |
| extra_words = [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sourcery 总结
优化
bad_words插件，以改进词语过滤和命令处理，并通过移除回复消息和预过滤不相关消息来简化限速器（rate limiter）行为。改进点：
check_bad_words函数，使其返回一个布尔值，并使用正确的jieba.cut参数，同时改进触发过滤器的群成员角色检查bad_words命令处理程序，以使用CommandArg，在未提供参数时提供当前状态，强制执行单参数验证，并标准化敏感词列表模式Original summary in English
Summary by Sourcery
Refine bad_words plugin to improve word filtering and command handling, and streamline rate limiter behavior by removing reply messages and pre-filtering irrelevant messages.
Enhancements: