Convert Everything to CSS Modules #1032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This converts the remainder of the CSS files to CSS modules. The following are not converted: 1. `variables.scss`: I'm not entirely sure if variables can be converted to CSS modules. The documentation states you might need PostCSS for it. However, we probably may want to look into CSS variables anyway. So this would be done in a subsequent PR. 2. `main.scss`: This declares global styles. I'm not sure if it's possible to convert this as this is needed from the very beginning, before any React is even loaded.
CryZe
added
enhancement
There was a problem hiding this comment.
Pull Request Overview
This PR primarily converts the remaining CSS files to CSS modules while excluding variable and global style declarations. In addition to CSS conversions, the PR includes adjustments in import paths in non-CSS files to accommodate the reorganization.
Files not reviewed (18)
- src/css/About.module.scss: Language not supported
- src/css/ButtonGroup.module.scss: Language not supported
- src/css/Font.scss: Language not supported
- src/css/Layout.module.scss: Language not supported
- src/css/LayoutEditor.module.scss: Language not supported
- src/css/LayoutEditor.scss: Language not supported
- src/css/Leaderboard.module.scss: Language not supported
- src/css/LiveSplit.module.scss: Language not supported
- src/css/LiveSplit.scss: Language not supported
- src/css/LiveSplitServerButton.module.scss: Language not supported
- src/css/Markdown.module.scss: Language not supported
- src/css/RunEditor.module.scss: Language not supported
- src/css/RunEditor.scss: Language not supported
- src/css/SettingsEditor.scss: Language not supported
- src/css/Sidebar.module.scss: Language not supported
- src/css/Sidebar.scss: Language not supported
- src/css/SplitsSelection.module.scss: Language not supported
- src/css/SplitsSelection.scss: Language not supported
Comments suppressed due to low confidence (1)
src/api/LiveSplitServer.ts:2
- Verify that the new import path '../util/LSOCommandSink' is correct based on the updated file structure to avoid any runtime issues.
import { LSOCommandSink } from "../util/LSOCommandSink";
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts the remainder of the CSS files to CSS modules. The following are not converted:
variables.scss: I'm not entirely sure if variables can be converted to CSS modules. The documentation states you might need PostCSS for it. However, we probably may want to look into CSS variables anyway. So this would be done in a subsequent PR.main.scss: This declares global styles. I'm not sure if it's possible to convert this as this is needed from the very beginning, before any React is even loaded.