Skip to content

chore: migrate to qt tray for all platforms#5260

Draft
ReenigneArcher wants to merge 2 commits into
masterfrom
chore/migrate-to-qt-tray
Draft

chore: migrate to qt tray for all platforms#5260
ReenigneArcher wants to merge 2 commits into
masterfrom
chore/migrate-to-qt-tray

Conversation

@ReenigneArcher
Copy link
Copy Markdown
Member

@ReenigneArcher ReenigneArcher commented Jun 7, 2026

Description

Migrates to QT tray on all platforms. Do not merge until after has merged. LizardByte/tray#145

TODO:

  • Test windows standalone version
  • Test windows service version
  • Test macOS

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 7, 2026

Bundle Report

Bundle size has no change ✅

@ReenigneArcher ReenigneArcher force-pushed the chore/migrate-to-qt-tray branch from 9c79ef9 to 8d22e8e Compare June 7, 2026 00:33
@ReenigneArcher ReenigneArcher force-pushed the chore/migrate-to-qt-tray branch 3 times, most recently from 3e71b5c to 0a970e1 Compare June 7, 2026 02:43
Introduce cmake/packaging/qt.cmake with sunshine_find_qt_tool and sunshine_require_qt_tool to locate Qt deployment tools. Wire macdeployqt into macos packaging (run during install to fix up .app bundles) when the tray backend is enabled, and integrate windeployqt into Windows packaging: add post-build deploy commands for binaries and run windeployqt at install time with curated options. These changes ensure Qt runtimes are bundled for the tray::tray backend on macOS and Windows.
@ReenigneArcher ReenigneArcher force-pushed the chore/migrate-to-qt-tray branch from 0a970e1 to 2d4b05e Compare June 7, 2026 03:20
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 7, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant