Remove dead stream-reader spikes (Channel, Pipeline, PipelineNew)#632
Merged
Conversation
These three readers were performance spikes attempting to beat .NET's buffered StreamReader. They were never wired into the ReaderType enum or the factory, so the factory could only ever produce Legacy, System, or SystemDirect. Channel and PipelineNew were referenced nowhere; Pipeline lived only in a doc comment and one test. The spikes' payoff was the finding that stream I/O is not the read-path bottleneck (buffer creation and line-location are) — already captured in PositionAwareStreamReaderDirect. The code artifacts are spent. - Delete Channel/Pipeline/PipelineNew (~2,186 lines) - Remove the 7 Pipeline* tests (seeking/unicode/max-length/empty-line behaviour is already covered by the System and Direct tests) - Update ILogStreamReader doc comment to list the three real readers and drop the NotSupportedException reference to the removed Pipeline reader The three-reader seam is kept deliberately: it varies across a speed-vs-format-robustness axis (see ADR 0006).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These three readers were performance spikes attempting to beat .NET's buffered StreamReader. They were never wired into the ReaderType enum or the factory, so the factory could only ever produce Legacy, System, or SystemDirect. Channel and PipelineNew were referenced nowhere; Pipeline lived only in a doc comment and one test.
The spikes' payoff was the finding that stream I/O is not the read-path bottleneck (buffer creation and line-location are) — already captured in PositionAwareStreamReaderDirect. The code artifacts are spent.
The three-reader seam is kept deliberately: it varies across a speed-vs-format-robustness axis.