security: fix CodeQL path-injection, stack-trace-exposure, and weak-crypto alerts - #60
Open
LoggeL wants to merge 1 commit into
Open
security: fix CodeQL path-injection, stack-trace-exposure, and weak-crypto alerts#60LoggeL wants to merge 1 commit into
LoggeL wants to merge 1 commit into
Conversation
…rypto alerts
Path injection (24 alerts across 3 files):
- src/utils/file_handling.py: Add _validate_song_path() helper using
pathlib.Path.resolve() + relative_to() containment check. Apply it
in get_song_dir() and delete_track() to ensure all paths derived from
user-supplied track IDs resolve strictly within SONGS_PATH.
- src/routes/admin.py: All 15 flagged path operations route through
get_song_dir() which now validates containment, closing the taint
flow from URL parameter to filesystem.
- src/services/reference_lyrics.py: Add _validate_file_path() to verify
vocals_path is within the songs directory before opening in
_fetch_openrouter().
Stack trace exposure (3 alerts in admin.py):
- fetch_reference_lyrics: Replace f'...{e}' response with generic
message; log full exception server-side via logging.exception().
- fetch_reference_lyrics_ai: Same pattern — generic response +
server-side logging.
- compress_songs: Replace print(f'...{e}') with logging.warning().
- song_details: Remove stack_trace field from API response to avoid
exposing internal tracebacks to clients.
Weak cryptographic algorithm (1 alert in deezer.py):
- Replace Crypto.Hash.MD5 with hashlib.md5(usedforsecurity=False).
MD5 is required by the Deezer download protocol for URL generation
and Blowfish key derivation — it cannot be replaced with a different
algorithm. The usedforsecurity=False flag (Python 3.9+) explicitly
marks this as non-security use, satisfying CodeQL.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| Raises ValueError if the resolved path escapes SONGS_PATH. | ||
| """ | ||
| resolved = Path(path).resolve() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 31 open CodeQL code-scanning alerts.
Path Injection (24 alerts — high)
Files:
src/utils/file_handling.py(9),src/routes/admin.py(15)Added
_validate_song_path()helper usingpathlib.Path.resolve()+relative_to()containment check. Applied inget_song_dir()anddelete_track()— the two functions where user-supplied track IDs are joined withSONGS_PATH. Since all 15 flagged path operations inadmin.pyroute throughget_song_dir(), fixing it at the source closes every taint flow from URL parameter → filesystem.Path Injection in reference_lyrics (3 alerts — high)
File:
src/services/reference_lyrics.pyAdded
_validate_file_path()that verifiesvocals_pathresolves within the songs directory before the file is opened in_fetch_openrouter(). Prevents crafted paths from reachingopen().Stack Trace Exposure (3 alerts — medium)
File:
src/routes/admin.pyfetch_reference_lyricsf"Lyrics fetch failed: {e}"with generic message; full trace logged vialogging.exception()fetch_reference_lyrics_aicompress_songsprint(f"...{e}")withlogging.warning(exc_info=True)song_detailsstack_tracefield from API responseWeak Cryptographic Algorithm (1 alert — high)
File:
src/services/deezer.pyReplaced
Crypto.Hash.MD5withhashlib.md5(data, usedforsecurity=False). MD5 is integral to the Deezer download protocol (URL key generation + Blowfish key derivation) and cannot be swapped for SHA-256. Theusedforsecurity=Falseflag (Python 3.9+) explicitly marks this as non-security use, which CodeQL recognizes as an acceptable exemption.Verification
All four modules import successfully under the project venv. MD5 output verified identical to previous implementation (
md5hex(b"hello")produces the expected5d41402abc4b2a76b9719d911017c592). Path traversal tests confirm_validate_song_path()rejects both absolute (/etc/passwd) and relative (../../etc/passwd) escapes.