[NeoForge 1.21.1] Critical Crash Fixes, Port Stabilization & ru_ru Locales#2513
Open
zevatov wants to merge 15 commits into
Open
[NeoForge 1.21.1] Critical Crash Fixes, Port Stabilization & ru_ru Locales#2513zevatov wants to merge 15 commits into
zevatov wants to merge 15 commits into
Conversation
…rge port Fixed final batch of compilation errors: - MobEffectInstance: fixed broken paren/semicolon from previous regex passes - RenderLaser/BeaconPotion: stubbed vertex chain (endVertex removed in 1.21.1) - BlockBeaconRedstone/BlockPotion: removed getBeaconColorMultiplier override conflict - ShieldCyclicItem: stubbed ShieldBlockEvent/LivingKnockBackEvent methods (API changed) - FishingEnderEntity: stubbed getLootTable (API changed) - SpikesDiamond: commented attackStrengthTicker (protected in 1.21.1) - SpikesBlock/FireEntity: setSecondsOnFire -> igniteForSeconds - BlockSimpleHopper: getShape/getInteractionShape protected -> Shapes.block() fallback - BlockMagnetPanel: removed unreachable return statement - ItemEvents: fixed EntityTickEvent->LivingEntity cast, shield event stubs - ScreenUser: fixed setTooltip(String) -> Tooltip.create() wrapper - ScreenCrafter: fixed partialTick variable name - ContainerBreaker: exposed public tile field for ScreenBreaker - CableBase: removed duplicate @OverRide annotation - BlockScaffoldingReplace/BlockItemInfinite: hand -> getMainHandItem() - Various: removed ForgeHooks/MinecraftForge/NetworkHooks legacy imports
…ned up temp scripts
…, removed 1.19 dead code
…rm items defaulting to OFF when crafted
…dd missing ru_ru translations, disable broken integration recipes, fix fluid container models
Updated the link for the required 'flib' library to point to the 1.21 compatible build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stabilizes the port to NeoForge 1.21.1 by addressing multiple fatal crashes during recipe registration, world load, and networking synchronization.
Warning
Disclaimer: This port and the associated bug fixes were developed and debugged with the assistance of an AI agent. While critical crashes have been fixed and basic functionality verified, it has not been thoroughly tested across all edge cases. Proceed with understanding that some latent bugs may still exist.
Key Changes & Fixes:
EncoderException: Empty FluidStack: Fixed the server kick issue on world load. ReplacedFluidStack.STREAM_CODECwithFluidStack.OPTIONAL_STREAM_CODECinRecipeMelterandRecipeCrusher. Sinceflib'sFluidTagIngredienthardcodes the strict codec, I implemented a custom inlineStreamCodecbypass inRecipeSolidifierandRecipeGeneratorFluidto allow empty fluids to sync safely.UnsupportedOperationException: Fixed the recipe manager crash. Swapped immutableNonNullList.ofto a mutable list usingNonNullList.create().addAll()inRecipeMelterandRecipeSolidifier.NullPointerException: Fixed crashes when JEI tries to render custom fluids (e.g.,xpjuice_bucket). InjectedinitializeClient()into all customFluid*Holder.javafiles to registerIClientFluidTypeExtensionstextures forDynamicFluidContainerModel.ItemProjectileDungeoninstantiating the eye but never adding it to the level. Added the missingworld.addFreshEntity(entityendereye)call.writeInt(slot)instead of aBlockPos.ru_ru.jsonkeys to achieve 100% localization parity.JsonParseExceptionand empty item crashes due to target mods altering their registries. Migrated legacy vanilla items (e.g.,minecraft:scute->minecraft:turtle_scute).(A
porting_summary.mdand updatedREADME.mdhave also been added to the root of the repository).