Add LtiAdvantage submodule, update LineItems view#8
Open
willwm wants to merge 27 commits intoLtiLibrary:masterfrom
Open
Add LtiAdvantage submodule, update LineItems view#8willwm wants to merge 27 commits intoLtiLibrary:masterfrom
willwm wants to merge 27 commits intoLtiLibrary:masterfrom
Conversation
Add LtiAdvantage submodule
…t score for line item when lineitem url is present.
Fix error when platform doesn't return line items. Add a way to submi…
Retrieve and display any context members on load
Display results on tool load
Retrieve line item data on load
Allow the resourcelinkid for a new line item to be specified
Allow for deletion of line items
…ange the token parameter name sent back to the Platform when assigning deeplinks to the standard "JWT" as defined in the spec at https://www.imsglobal.org/spec/security/v1p0/#form-parameter
Fix the redirect to the /Catalog page on a DeepLinkRequest launch. Ch…
Generate correct tool Url when assigning a deep link item
Display custom params from launch request
|
Hey learningcom team, I am new to LTI and edtech was wondering if this is actually up to date and up to standards of the LTI 2.0/LTI advantage given that the readme of both this and your fork say its out of date. |
johnmweisz
reviewed
Sep 10, 2021
| var lineItemClient = _httpClientFactory.CreateClient(); | ||
| lineItemClient.SetBearerToken(tokenResponse.AccessToken); | ||
| lineItemClient.DefaultRequestHeaders.Accept | ||
| .Add(new MediaTypeWithQualityHeaderValue(Constants.MediaTypes.LineItem)); |
There was a problem hiding this comment.
This is requesting media type LineItem but expecting a ResultContainer response.
johnmweisz
reviewed
Sep 13, 2021
| lineItemClient.DefaultRequestHeaders.Accept | ||
| .Add(new MediaTypeWithQualityHeaderValue(Constants.MediaTypes.LineItem)); | ||
|
|
||
| var resultsUrl = $"{LtiRequest.AssignmentGradeServices.LineItemUrl}/{Constants.ServiceEndpoints.Ags.ResultsService}"; |
There was a problem hiding this comment.
this breaks if the platform includes query params in the uri
rajibFevtutor
approved these changes
Jan 24, 2022
rajibFevtutor
approved these changes
Jan 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes changes from the following downstream PRs: