Automatic definition updates #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Good catch that it reverts some of my work. I agree it should be in the Wiki as well. I make no guarantees I'll be able to add it clearly to the official Wiki. I'm looking to see if there is a way to group types together in the wiki; I'm very inexperienced in adding to wiki pages. It seems it would be very redundant for a wiki to have the same information repeated for just changing "string" to "number". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With regards to #4 I wrote an update script, fetching the most recent love-api.
I also added support for array types with LuaLS/lua-language-server#2979
Notice that this PR undos some work of @JJSax as those fixes should be added to the love-api and the wiki directly imo.