Conversation
BriceFrancois
previously approved these changes
Jun 19, 2025
| } | ||
| } | ||
| Task SendAsync(Sample sample); | ||
| Task ConsumeAsync(EventHandler<Sample> onSampleReceived); |
Contributor
There was a problem hiding this comment.
on garde un EventHandler standard en fin de compte,
on arrive à se passer de l'implem de RabbitMQ.Client ?
Contributor
Author
There was a problem hiding this comment.
Sur le Consume ils ont gardé l'EventHandler côté lib, c'est pour le Stop que ça a changé
| } | ||
|
|
||
| public void StopConsuming(EventHandler onConsumerStopped) | ||
| public async Task StopConsuming(AsyncEventHandler<ConsumerEventArgs> onConsumerStopped) |
Contributor
There was a problem hiding this comment.
ah ici 😞
le StopConsuming est sur l'interface IConsumer j'imagine
| { | ||
| var basicProperties = CreateBasicProperties(message); | ||
| var addr = new PublicationAddress("", ExchangeName, message.GetRoutingKey()); | ||
| using var cts = new CancellationTokenSource(new TimeSpan(TimeoutInMilliseconds * TimeSpan.TicksPerMillisecond)); |
| } | ||
| public async Task DeclareExchangeAsync(string exchangeName, string exchangeType) | ||
| { | ||
| if (string.IsNullOrWhiteSpace(exchangeName)) throw new ArgumentNullException(nameof(exchangeName)); |
Contributor
There was a problem hiding this comment.
Suggested change
| if (string.IsNullOrWhiteSpace(exchangeName)) throw new ArgumentNullException(nameof(exchangeName)); | |
| ArgumentNullException.ThrowIfNullOrWhiteSpace(exchangeName); |
Contributor
Author
There was a problem hiding this comment.
Pas dispo ici apparement :(
| return DeclareQueue(queueName, queueArgs, isQuorum); | ||
| public Task<string> DeclareQueueWithDeadLetterPolicyAsync(string queueName, string deadLetterExchange, int messageTimeToLive, string deadLetterRoutingKey, bool isQuorum) | ||
| { | ||
| if (string.IsNullOrWhiteSpace(deadLetterExchange)) throw new ArgumentNullException(nameof(deadLetterExchange)); |
Contributor
There was a problem hiding this comment.
Suggested change
| if (string.IsNullOrWhiteSpace(deadLetterExchange)) throw new ArgumentNullException(nameof(deadLetterExchange)); | |
| ArgumentNullException.ThrowIfNullOrWhiteSpace(deadLetterExchange); |
| if (queueArgs == null) throw new ArgumentNullException(nameof(queueArgs)); | ||
| public async Task<string> DeclareQueueAsync(string queueName, Dictionary<string, object> queueArgs, bool isQuorum) | ||
| { | ||
| if (string.IsNullOrWhiteSpace(queueName)) throw new ArgumentNullException(nameof(queueName)); |
Contributor
There was a problem hiding this comment.
Suggested change
| if (string.IsNullOrWhiteSpace(queueName)) throw new ArgumentNullException(nameof(queueName)); | |
| ArgumentNullException.ThrowIfNullOrWhiteSpace(queueName); |
| public async Task DeclareBindingAsync(string exchangeName, string queueName, string routingKey, Dictionary<string, object> headerBindings) | ||
| { | ||
| if (string.IsNullOrWhiteSpace(exchangeName)) throw new ArgumentNullException(nameof(exchangeName)); | ||
| if (string.IsNullOrWhiteSpace(queueName)) throw new ArgumentNullException(nameof(queueName)); |
bebelz
force-pushed
the
bump.rabbitmq.client
branch
from
aa7b730 to
1aace47
Compare
BriceFrancois
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tout passe asyc, nécessaire pour les projets utilisant aussi
Lucca.Core.Eventset qui veulent passer en version 8+ (https://github.com/LuccaSA/Lucca.Core.Events/releases/tag/v8.0.0)rabbitmq/rabbitmq-dotnet-client#1720
https://github.com/rabbitmq/rabbitmq-dotnet-client/blob/main/v7-MIGRATION.md
AsyncEventHandleren signature deUnregisteredAsyncqui est une implémentation de RabbitMqClient.