Remove CAR.COROLLA from DSU static messages in Toyota values#28
Open
Copilot wants to merge 2 commits into071_OC_WATERfrom
Open
Remove CAR.COROLLA from DSU static messages in Toyota values#28Copilot wants to merge 2 commits into071_OC_WATERfrom
Copilot wants to merge 2 commits into071_OC_WATERfrom
Conversation
Co-authored-by: Lukilink <41362285+Lukilink@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Entferne CAR.TOYOTA_COROLLA aus STATIC_DSU_MSGS
Remove CAR.COROLLA from DSU static messages in Toyota values
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
CAR.COROLLAfrom all DSU-related tuples in theSTATIC_MSGSlist inselfdrive/car/toyota/values.py.Changes Made
Removed
CAR.COROLLAfrom 9 static message entries that useECU.DSU:0x128- DSU message with various Toyota models0x141- DSU message with extended model list0x160- DSU message with extended model list0x161- DSU message with core Toyota models0x283- DSU message with extended model list0x344- DSU message with extended model list0x365- DSU message with RAV4/Corolla subset0x366- DSU message with RAV4/Corolla subset0x4CB- DSU message with extended model listWhat Was Preserved
CAR.COROLLAreferences remain intact (fingerprints, DBC mappings, firmware versions, car lists)CAR.COROLLA_TSS2andCAR.COROLLAH_TSS2are unchangedExample Change
Before:
After:
The changes ensure that DSU (Driving Support Unit) static messages are no longer sent for the Corolla model while maintaining all other Toyota vehicle configurations.
This pull request was created as a result of the following prompt from Copilot chat.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.