Skip to content

Remove CAR.COROLLA from DSU static messages in Toyota values#28

Open
Copilot wants to merge 2 commits into071_OC_WATERfrom
copilot/fix-092fccb5-8413-4f05-b401-c40e14ee0517
Open

Remove CAR.COROLLA from DSU static messages in Toyota values#28
Copilot wants to merge 2 commits into071_OC_WATERfrom
copilot/fix-092fccb5-8413-4f05-b401-c40e14ee0517

Conversation

Copy link

Copilot AI commented Jul 20, 2025

This PR removes CAR.COROLLA from all DSU-related tuples in the STATIC_MSGS list in selfdrive/car/toyota/values.py.

Changes Made

Removed CAR.COROLLA from 9 static message entries that use ECU.DSU:

  • 0x128 - DSU message with various Toyota models
  • 0x141 - DSU message with extended model list
  • 0x160 - DSU message with extended model list
  • 0x161 - DSU message with core Toyota models
  • 0x283 - DSU message with extended model list
  • 0x344 - DSU message with extended model list
  • 0x365 - DSU message with RAV4/Corolla subset
  • 0x366 - DSU message with RAV4/Corolla subset
  • 0x4CB - DSU message with extended model list

What Was Preserved

  • All other CAR.COROLLA references remain intact (fingerprints, DBC mappings, firmware versions, car lists)
  • CAR.COROLLA_TSS2 and CAR.COROLLAH_TSS2 are unchanged
  • Tuple structure and formatting maintained
  • No functional changes to non-DSU messages

Example Change

Before:

(0x128, ECU.DSU, (CAR.PRIUS, CAR.RAV4H, CAR.LEXUS_RXH, CAR.RAV4, CAR.COROLLA, CAR.AVALON, CAR.OLD_CAR), 1, 3, b'\xf4\x01\x90\x83\x00\x37')

After:

(0x128, ECU.DSU, (CAR.PRIUS, CAR.RAV4H, CAR.LEXUS_RXH, CAR.RAV4, CAR.AVALON, CAR.OLD_CAR), 1, 3, b'\xf4\x01\x90\x83\x00\x37')

The changes ensure that DSU (Driving Support Unit) static messages are no longer sent for the Corolla model while maintaining all other Toyota vehicle configurations.

This pull request was created as a result of the following prompt from Copilot chat.

Entferne CAR.TOYOTA_COROLLA aus allen Tupeln in der Liste STATIC_DSU_MSGS im File selfdrive/car/toyota/values.py. Achte darauf, dass CAR.TOYOTA_COROLLA nur entfernt wird, die anderen Einträge aber erhalten bleiben. Beispiel: (0x128, (CAR.TOYOTA_PRIUS, CAR.TOYOTA_RAV4H, CAR.LEXUS_RX, CAR.LEXUS_NX, CAR.TOYOTA_RAV4, CAR.TOYOTA_COROLLA, CAR.TOYOTA_AVALON), ...) soll zu (0x128, (CAR.TOYOTA_PRIUS, CAR.TOYOTA_RAV4H, CAR.LEXUS_RX, CAR.LEXUS_NX, CAR.TOYOTA_RAV4, CAR.TOYOTA_AVALON), ...) werden. Führe dies für alle Vorkommen in STATIC_DSU_MSGS durch.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

@Lukilink Lukilink marked this pull request as ready for review July 20, 2025 21:18
Co-authored-by: Lukilink <41362285+Lukilink@users.noreply.github.com>
Copilot AI changed the title [WIP] Entferne CAR.TOYOTA_COROLLA aus STATIC_DSU_MSGS Remove CAR.COROLLA from DSU static messages in Toyota values Jul 20, 2025
Copilot AI requested a review from Lukilink July 20, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants