Skip to content

Conversation

@dzmitrykruchko-nbcuni
Copy link
Contributor

No description provided.

@marcoscano marcoscano self-requested a review February 19, 2024 13:45
Copy link
Collaborator

@marcoscano marcoscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I wonder if there are other places in the library that are no longer compatible, but I think we'll end up finding out as we move forward. I am OK doing it iteratively.

There is a failure in CircleCI code inspections but I am not sure if they come from this PR, maybe we can try to fix it before merging if that's the case?

The command being run in CI is:

vendor/bin/php-cs-fixer fix --config=.php-cs-fixer.dist.php -v --dry-run --using-cache=no --path-mode=intersection -- src tests

@dzmitrykruchko-nbcuni
Copy link
Contributor Author

This looks good to me. I wonder if there are other places in the library that are no longer compatible, but I think we'll end up finding out as we move forward. I am OK doing it iteratively.

There is a failure in CircleCI code inspections but I am not sure if they come from this PR, maybe we can try to fix it before merging if that's the case?

The command being run in CI is:

vendor/bin/php-cs-fixer fix --config=.php-cs-fixer.dist.php -v --dry-run --using-cache=no --path-mode=intersection -- src tests

The tests issue is not related to the changes in this PR as Found 45 of 178 files that can be fixed
We can apply CS Fixer fixes here, but i think it makes sense to do it in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants