Skip to content

Conversation

@Jade-TheCat
Copy link

This enables use of the Betacraft Proxy for custom legacy skins.

I use a custom skin on the Betacraft Proxy in order to have a separate skin for older versions, so this will allow the usage of that proxy. There might be a better way to do this by calling Betacraft directly, but I don't know how one would even do that. There doesn't seem to be any documentation on the website for that, so I am currently assuming that is impossible without going through the HTTP proxy.

@Jade-TheCat
Copy link
Author

Updated the PR to fix #36 as well since I found the problem I think

@PhoenixVX
Copy link
Member

PhoenixVX commented Dec 27, 2025

You could use Betacraft directly by switching the URLs over to http://betacraft.uk:11703 where 11703 is the port number for the game version you are using. It isn't recommended for a variety of reasons though.

Can't say anything for the latter as it is hard to review on phone.

@PhoenixVX
Copy link
Member

An alternative implementation to consider is disabling skinfix and other proxied requests when a proxy is enabled.

Just my 2 cents, Lassebq has a better understanding of LW than I do.

@Lassebq
Copy link
Member

Lassebq commented Dec 27, 2025

Can you remind me please, does -Dhttp.proxyHost=betacraft.uk take presence over LaunchWrapper's skinfix? Or does it not work at all?

@PhoenixVX
Copy link
Member

As an aside, signature changes for methods require a version bump (as it is the same as deleting a method and making a new one). To be honest, the old method should probably be preserved with @Deprecated on it as a just-in-case any old code uses it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants