Updated test logic and Updated Effinitive version to 2.1.3#853
Draft
HBartosch wants to merge 10 commits into
Draft
Updated test logic and Updated Effinitive version to 2.1.3#853HBartosch wants to merge 10 commits into
HBartosch wants to merge 10 commits into
Conversation
…rties initialization
…eadability and maintainability
HBartosch
changed the title
…ting properties in ProcessedItem class
Contributor
Author
|
/benchmark -f effinitive |
Contributor
|
👋 |
Contributor
Benchmark ResultsFramework:
Full log |
Contributor
|
/benchmark -f effinitive --save |
Contributor
|
👋 |
Contributor
|
|
Contributor
Author
|
/benchmark -f effinitive --save |
Contributor
|
👋 |
Contributor
Benchmark ResultsFramework:
Full log |
Owner
|
This is not how a static file works, you can't preload all files into an app managed heap snapshot and serve them. Also a lot of inconsistency and clearly blindly vibe coded logic in this file.. Please fix this or I have to move it into engine section. Comments in a framework source core with "// The benchmark sends "br;q=1, gzip;q=0.8" so br is explicitly preferred." are certainly not acceptable. |
Contributor
Author
|
Missed this in my review. Will keep an eye out for things like this thanks. |
Contributor
Author
|
Deprecated the packages to not use the packages for the new versions. will be reworking this section. Again. Really appreciate it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated test logic and Updated Effinitive version to 2.1.1
PR Commands — comment on this PR to trigger (requires collaborator approval):
/benchmark -f <framework>/benchmark -f <framework> -t <test>/benchmark -f <framework> --saveAlways specify
-f <framework>. Results are automatically compared against the current leaderboard.Run benchmarks locally
You can validate and benchmark your framework locally with the lite script — no CPU pinning, fixed connection counts, all load generators run in Docker.
Requirements: Docker Engine on Linux. Load generators (gcannon, h2load, h2load-h3, wrk, ghz) are built as self-contained Docker images on first run.