Prevent duplicate GameScope creation when other mods interfere w… #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith GameStart patch Add protection mechanism to prevent IoC container from being created multiple times in the same game session. This fixes an issue where other mods' prefix patches that return false and manually call the original method would cause the postfix to be executed twice, leading to duplicate scope creation. - Add _isGameScopeActive flag to track if a game scope is currently active - Check flag in CreateGameScope() to prevent duplicate creation - Reset flag in DisposeCurrentScope() when cleaning up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add protection mechanism to prevent IoC container from being created multiple times in the same game session. This fixes an issue where other mods' prefix patches that return false and manually call the original method would cause the postfix to be executed twice, leading to duplicate scope creation.