Skip to content

Features/nialljmiller/customcolors update0 #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pmocz merged 53 commits into from
Jan 13, 2026
Merged

Features/nialljmiller/customcolors update0 #909

pmocz merged 53 commits into from
Jan 13, 2026

Conversation

@nialljmiller
Copy link
Collaborator

@nialljmiller nialljmiller commented Jan 7, 2026

  • Moved data from colors/data to data/colors_data
  • Precalculate zero points on module load
  • SED data is cached at module load to remove file IO

nialljmiller and others added 30 commits December 12, 2025 11:31
@nialljmiller
[ci skip] minor change to python helper so different filters work.
a9e8467
@nialljmiller
[ci skip] readme updates, still WIP
d05c30b
@nialljmiller
[ci skip] new python visualisations for interpolation distance
90da5df
@nialljmiller
added interpolation radius to allow for quality checks in custom colo…
fbd6048 
…rs + added select case for those wishing to change interpolation method -- this still needs to be piped to a user option
@nialljmiller
[ci skip] updating python helpers now so later commit is easier
877ac6a
@nialljmiller
[ci skip] added zero point defined by user]
af3ae8e
@nialljmiller
[ci skip] added user defined zero point
bc808ea
@nialljmiller
[ci skip]
f45b50d 
 updating colors data file
@nialljmiller
[ci skip] WIP README, new format and overview.
79f1c17
@nialljmiller
[ci skip] changed defaults to Johnson UBVRI
b4a228b
@nialljmiller
readme update
a56c1ae
@nialljmiller
[ci skip] pulling updates
c966e94
@nialljmiller
[ci skip] Update distance value in colors.defaults to 10pc
4aec62d
@nialljmiller
[ci skip] cleaning
9d85308
@nialljmiller
[ci skip] pg star
e1b6112
@nialljmiller
[ci skip] inlists
45f6452
@nialljmiller
[ci skip] updated defaults
9f3ca31
@nialljmiller
[ci skip] make_CMD_InterpRad_movie.py
9925eb2
@nialljmiller
Update README.rst
d691681
@nialljmiller
Update README.rst
b11a20b
@nialljmiller
[ci skip] Enhance README with parameter examples
bb744f8 
Added examples for various parameters in README.
@nialljmiller
[ci skip] added management for missing columns in stellar atm tables
9e910dd
@nialljmiller
[ci skip] inlist update
790eebc
@nialljmiller
Update README.rst
f4712f7
@nialljmiller
Enhance README with test suite details and usage
854659b 
Expanded the README to include detailed descriptions of the test suite's functionality, output, and purpose. Added sections on real-time visualization and inlist options.
@nialljmiller
Create README.rst
9f2acff
@nialljmiller
[ci skip] removed old python helpers from /colors/ as they are now de…
cb58e54 
…precated with https://github.com/nialljmiller/SED_Tools
@nialljmiller
cleaning for merge
d37fc02
@pmocz
lintinh
085a87e
@nialljmiller
adding new colors data
ff82fc2
pmocz and others added 16 commits December 16, 2025 12:23
@pmocz
change colors test termination condition
501c908
@pmocz
make sure to save final.mod in colors testing
45fb034
@pmocz
add final modl name
c6a75bc
@nialljmiller
fixing bug found in usage of clight where the wrong units were assume…
6dab6ad 
…d for AB zeropoint. Also fixed Vega zero point interpolation error.
@nialljmiller
Merge remote-tracking branch 'origin/main' into features/nialljmiller…
48b8e84 
…/customcolors_update0
@nialljmiller
[ci skip] cleaning files
821fd4a
@nialljmiller
Merge remote-tracking branch 'origin/main' into features/nialljmiller…
83cacd2 
…/customcolors_update0
@nialljmiller
built with SDK 25.12.1
cef0c27
@nialljmiller
moved colors data from colors/data to data/colors_data
faf0cdc
@nialljmiller
[ci skip] Added more files for moving the data.
3adc73f
@nialljmiller
[ci skip] removing junk
3051763
@nialljmiller
[ci skip] removing file io junk
4c45066
@nialljmiller
[ci skip] updates on file io operations. zero points are calculated a…
d9e66b3 
…t initilisation and SED tables are cached at initialiation.
@nialljmiller
[ci skip] updates for history files and python helpers
470f9eb
@nialljmiller
Merge remote-tracking branch 'origin/main' into features/nialljmiller…
0a97c82 
…/customcolors_update0
@nialljmiller
fixed inlist
618a50f
@nialljmiller nialljmiller requested a review from rsmolec as a code owner January 7, 2026 18:26
warrickball
warrickball reviewed Jan 8, 2026
View reviewed changes
warrickball
warrickball reviewed Jan 8, 2026
View reviewed changes
nialljmiller and others added 2 commits January 7, 2026 23:40
@nialljmiller @warrickball
Apply suggestions from code review
9d064fe 
removing unnecessary redefine of dp.

Co-authored-by: Warrick Ball <W.H.Ball@bham.ac.uk>
@pmocz
[ci skip] docs linting
4c29705
@pmocz
Copy link
Member

pmocz commented Jan 9, 2026

Thanks for updating this, Niall!

@pmocz pmocz self-requested a review January 9, 2026 21:07
@pmocz pmocz merged commit b087d9a into main Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warrickball warrickball warrickball left review comments

@pmocz pmocz pmocz approved these changes

@rsmolec rsmolec Awaiting requested review from rsmolec rsmolec is a code owner

Assignees

@pmocz pmocz

@mjoyceGR mjoyceGR

@nialljmiller nialljmiller

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nialljmiller @pmocz @warrickball @mjoyceGR