Allow other mods to override the suggested filters #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice if other mods had a way to override the suggested filters, mainly in the case of compound entities.
I tried adding support for this back in the 1.1 days for https://mods.factorio.com/mod/factoryplanner-is-exportable-to-fake-factorissimo but doing whitelisting back then through remote interfaces just became an ugly mess so i put it aside.
Now that we have mod-data since 2.0.58 i gave it another attempt for the 2.0 port of the above mod called https://mods.factorio.com/mod/magic-huts.
The current implementation is still a bit crude but it appears to work, i still plan to clean up this pr like fixing the check at the beginning and trying to smooth it out a bit, like allowing passing nil to skip the override or to allow merging it with the fuel & spoil result stuff, so for now this'll just be a manual change players should make to the mod locally in order to have it compatible with the experimental code i just pushed here:
Quezler/glutenfree@996d6fd