Skip to content

Fix units mismatch when calculating water mass #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Calebsakhtar wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix units mismatch when calculating water mass #86

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fea56f
Fix units mismatch when calculating water mass
Calebsakhtar Jan 7, 2026
4ceeaf9
Add a print statement with the water difference
Calebsakhtar Jan 7, 2026
d0fa9c8
Remove the debugging print statement
Calebsakhtar Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Code.v05-00/src/Core/LAGRIDPlumeModel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,8 +325,8 @@ void LAGRIDPlumeModel::initH2O() {
auto areas = VectorUtils::cellAreas(xEdges_, yEdges_);
const double icemass = iceAerosol_.TotalIceMass_sum(areas);

double mass_WV = WV_exhaust_ - icemass;
double E_H2O = mass_WV / (MW_H2O * 1e3) * Na;
double mass_WV = WV_exhaust_ / 1e3 - icemass; // WV_exhaust converted from [g/m] -> [kg/m]
double E_H2O = mass_WV / (MW_H2O) * Na;

// Spread the emitted water evenly over the cells that contain ice crystals
auto localPlumeEmission = [&](std::size_t j, std::size_t i) -> double {
Expand Down