Skip to content

Conversation

@JPrevost
Copy link
Member

@JPrevost JPrevost commented May 5, 2025

To test:

Confirm playground works in this PR build.

Compare to playground not working in production TIMDEX.

4.x recently was released and breaks our example.

I'll open a ticket to upgrade to 4, but it was not going to be quick so this will be a stop gap.

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

YES | NO

Includes new or updated dependencies?

YES | NO

4.x recently was released and breaks our example.

I'll open a ticket to upgrade to 4, but it was not going to be quick so this will be a stop gap.
@mitlib mitlib temporarily deployed to timdex-pr-861 May 5, 2025 14:33 Inactive
@JPrevost JPrevost merged commit a30b117 into main May 5, 2025
4 checks passed
@JPrevost JPrevost deleted the pin-graphiql-playground-version branch May 5, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants