[pull] main from llvm:main - #1708
Merged
Merged
Conversation
…d link errors (#213508) An undefined symbol error when building Flang in debug mode. This PR fix this by remove unused include file. Here is a brief error log: `/usr/bin/ld:lib/libFIRBuilder.a(MIFCommon.cpp.o): in function Fortran::evaluate::FunctionRef<Fortran::evaluate::Type<(Fortran::common::TypeCategory)4, 1> >::~FunctionRef()':`.
Firstly, by overwriting the symbol, it will have its existing flags, so there is no need to copy them back; all we need to do is mask out the other bits on the existing symbol. Secondly, copying the whole symbol just to preserve the symbol version that gets cleared by Defined::overwrite is a waste; just copy the single member to reinstate it.
#213476) InstCombine canonicalizes sub nsw i8 -1, %a -> xor i8 %a, -1. Decompose the XOR as `sub nsw -1, %a` in the signed system Alive2 Proof: https://alive2.llvm.org/ce/z/f_YVjH This triggers quite rarely in C/C++ workloads (no end-to-end changes in dtcxzyw/llvm-opt-benchmark-nightly#840), found one instance in Blender. One simple end-to-end C example is https://clang.godbolt.org/z/G343shYje This is part of an effort to improve ConstraintElimination support for IR generated by the Swift compiler, where such patterns are more common due to a number of signed runtime checks. PR: #213476
…ounds (#211960) Split evaluatePtrAddRecAtMaxBTCWillNotWrap into two stages: compute MaxOffset based on the step direction, then apply the shared MaxOffset <= DerefBytes check. Rename intermediate values to reflect what they actually represent. This restructuring makes two long-standing off-by-EltSize issues in the negative-step path explicit: * The lower-bound check is over-conservative by EltSize. * The upper-bound check under-counts by EltSize.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )