Skip to content

Cursor/audit security hardening#4

Merged
MParvin merged 3 commits into
masterfrom
cursor/audit-security-hardening
Jul 19, 2026
Merged

Cursor/audit security hardening#4
MParvin merged 3 commits into
masterfrom
cursor/audit-security-hardening

Conversation

@MParvin

@MParvin MParvin commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Note

Medium Risk
Touches authentication, path/SSRF controls, and optional engine planning/execution paths; defaults keep v2 flags off, but misconfiguration or regressions in permission checks could block legitimate tool use or leave browser/HTTP exposure if health or WS ports are bound broadly.

Overview
This PR tightens the security posture and expands operability while optionally enabling v2 planning/execution behind feature flags.

Security & safety: Docker isolation runs commands as argv (no sh -c). Filesystem/git paths use symlink-aware resolution; empty allow_paths now denies access. The HTTP tool adds SSRF-safe dialing and redirect checks. Browser WebSocket auth prefers Sec-WebSocket-Protocol: octaai.<token>, rejects empty Origin, and config saves at 0600 without logging full browser tokens. SQLite opens with WAL and busy timeout.

Engine & daemon: features.use_htn_planner, use_dag_executor, and use_capabilities wire HTN planning (with v1 fallback), pkg/executor scheduling, and the builtin capability registry. The daemon exposes --health-addr with /healthz and /readyz. CI moves to Go 1.25.x, adds make lint, a 20% coverage gate, and govulncheck; make live-test and Docker/health docs are added.

Tests & docs: Broad unit coverage (permission, browser, engine, planner, storage, tools) plus roadmap/log docs and an in-repo Firefox addon; memory is documented as TF-IDF, not vector DB.

Reviewed by Cursor Bugbot for commit 5b95584. Bugbot is set up for automated code reviews on this repo. Configure here.

MParvin and others added 3 commits July 18, 2026 19:37
Close audit P0/P1 gaps with symlink-aware paths, no sh -c in Docker, HTTP dialer guards, safer browser WS auth, private config mode, and govulncheck in CI.

Co-authored-by: Cursor <cursoragent@cursor.com>
Enable gradual v2 planner/scheduler paths behind config flags, add /healthz and /readyz, and document the wired versus unimplemented features.

Co-authored-by: Cursor <cursoragent@cursor.com>
@cursor

cursor Bot commented Jul 19, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_5e0e681a-128a-4c3a-88ad-6fb35b3e565f)

@MParvin
MParvin merged commit 9449897 into master Jul 19, 2026
1 of 2 checks passed
@MParvin
MParvin deleted the cursor/audit-security-hardening branch July 19, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant