Display main pass progression using tqdm instead of prints#170
Merged
Conversation
J-Endres
approved these changes
May 26, 2026
J-Endres
added a commit
that referenced
this pull request
Jun 9, 2026
* Add frequency domain to pulse as parameters. * Fix typo in documentation comment * Update pyproject.toml for version 0.4.7 (#167) * Update pyproject.toml for version 0.4.7 I dont know if this is the best solution, but it is one solution. Updated version to 0.4.7 and changed requires-python to >=3.10, needed for some phantoms. Added optional dependencies section for pypulseq. so pip install mrzerocore[pp14] installs with pypulseq <1.5 * quick test if tests run with 1.4.2post2 * add seq importer based on pulseq_rs * integrate pulseq labels into mrzero seq * update version to 0.4.8 * Display main pass progression using tqdm instead of prints (#170) * fix sig_to_mrd (#171) * fix sig_to_mrd * re-trigger ci * update pyproject version number * fix ismrmrd v2 * Add frequency domain to pulse as parameters. * Fix typo in documentation comment * update mrzerocore version --------- Co-authored-by: mzaiss <mzaiss@users.noreply.github.com> Co-authored-by: J-Endres <jonathan.endres01@gmail.com> Co-authored-by: Laurent Brock <91371894+lobroc@users.noreply.github.com> Co-authored-by: J-Endres <67545816+J-Endres@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greetings. Thought I'd add monitoring of the main pass using tqdm, as when doing longer runs, it becomes quite hard to estimate time remaining from process wall time + repetition count. I run simulations spanning multiple hours, and this would be highly useful. Changes are quite small, only a few lines.
Not adding in the tqdm dependency, already included in the project.