ci: move setup-uv and test-reporter off the Node 20 runtime#13
Open
MacBuchi wants to merge 1 commit into
Open
Conversation
astral-sh/setup-uv v5 -> v7 dorny/test-reporter v1 -> v3 Note the target for setup-uv is v7, not v8 as issue #11 claimed: the project publishes floating major tags only up to v7. The v8.x releases exist but no v8 alias does, so `@v8` would not resolve. v7 is already node24, which is what this is about. Both majors carry breaking changes; neither touches how this repo uses them: - setup-uv v6 stopped auto-activating a venv for `python-version` and changed the default cache-dependency-glob, the working-directory handling and the self-hosted cache dir. The workflows here pass only `enable-cache: true` and install Python in a separate `uv python install` step, so none of that applies. v7 additionally drops the deprecated `server-url` input, also unused. - test-reporter v3 is the Node 24 bump plus a switch to declaring the lowest required permissions. The test job already grants `checks: write`, so publishing the check run keeps working. All four inputs the reporter is given (name, path, reporter, fail-on-error) still exist in v3, and enable-cache still exists in v7 — checked against each target's action.yml. Closes #11 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11 — second of two. Stacked on #12; base retargets to
Mainonce that merges. Stacked rather than parallel because theseuses:lines sit within three lines of the ones #12 touches, so two independent branches would conflict.astral-sh/setup-uvdorny/test-reporterCorrection to the issue
Issue #11 names v8 as the setup-uv target. That is wrong: the project publishes floating major tags only up to
v7. Thev8.xreleases exist, but nov8alias does —@v8would not resolve at all.v7is alreadynode24, which is the point of this change.Breaking changes, and why none of them bite here
I read both changelogs rather than assuming a drop-in swap. Both majors do carry breaking changes; neither touches how this repo uses the action:
setup-uv v6 stopped auto-activating a venv when
python-versionis set (newactivate-environmentinput, defaultfalse), and changed the defaultcache-dependency-glob, theworking-directoryhandling and the self-hosted cache dir. These workflows pass onlyenable-cache: trueand install Python in a separateuv python install 3.13step — they never setpython-version,activate-environment,working-directoryorcache-dependency-glob. v7 additionally removes the deprecatedserver-urlinput, also unused here.test-reporter v3 is the Node 24 bump plus a switch to declaring the lowest permissions it needs. That is the one that could have bitten: the action publishes a check run and needs
checks: write. Thetestjob already grants it (ci.yml:42-44), so the report keeps working.Inputs verified against each target's
action.yml:enable-cache(setup-uv v7);name,path,reporter,fail-on-error(test-reporter v3).Verification
All three workflows parse (
YAML.load_file). This PR's CI exercises both actions directly —setup-uvin every job andtest-reporterin the test job — so unlike #12 this one is genuinely proven by its own run. Worth checking the run's Checks tab for the "Pytest Results" check run, sincefail-on-error: falsemeans a publishing failure would be silent.🤖 Generated with Claude Code