Desktop notifications#31
Open
nicolasberens wants to merge 3 commits intoMach5:masterfrom
nicolasberens:desktop_notification
Open
Desktop notifications#31nicolasberens wants to merge 3 commits intoMach5:masterfrom nicolasberens:desktop_notification
nicolasberens wants to merge 3 commits intoMach5:masterfrom
nicolasberens:desktop_notification
Conversation
Member
|
Code looks good. I am going to leave this open until we figure out the album art URL. Please reference this issue in future commit messages. tracking @ supersonic/desktop_notifcations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basicaly i stole the code from http://forum.subsonic.org/forum/viewtopic.php?p=22104#p22104 and tested it, for me it works.
Whats imho needs to be done is to replace the paly images with the album cover, but i dont know how to find out the url of the cover art (btw: the cover shown in the now playing area on the right side should be in the right size for this )