Skip to content

Feature/avx512 excess#43

Merged
Malkovsky merged 7 commits into
mainfrom
feature/avx512_excess
Apr 27, 2026
Merged

Feature/avx512 excess#43
Malkovsky merged 7 commits into
mainfrom
feature/avx512_excess

Conversation

@Malkovsky
Copy link
Copy Markdown
Owner

Implementation of excess via AVX-512

Comment thread include/pixie/bits.h Outdated
#define PIXIE_AVX512VBMI_SUPPORT
#endif

#if defined(__GFNI__) && defined(PIXIE_AVX512_SUPPORT) && \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: PIXIE_AVX512GFNI_SUPPORT can enable a code path that requires VBMI intrinsics

The excess_interleave_masks_gfni implementation uses _mm512_permutexvar_epi8, which requires AVX-512 VBMI. This macro gate currently checks __GFNI__ but not __AVX512VBMI__, so builds with GFNI enabled but VBMI disabled can fail to compile. Please include __AVX512VBMI__ in the feature gate (or avoid VBMI-only intrinsics in this path).

@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented Apr 26, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 files)
  • include/pixie/bits.h

Reviewed by gpt-5.3-codex · 354,413 tokens

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.40%. Comparing base (afe4b2e) to head (0bd066f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   87.29%   87.40%   +0.10%     
==========================================
  Files          12       12              
  Lines        3118     3136      +18     
  Branches      612      607       -5     
==========================================
+ Hits         2722     2741      +19     
+ Misses        260      259       -1     
  Partials      136      136              
Flag Coverage Δ
gcov 87.40% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Malkovsky Malkovsky merged commit 58fc9fa into main Apr 27, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant