Skip to content

chore: remove unused gitHash function and update AS requirements due to AGP 9.1.0 upgrade#221

Merged
Manabu-GT merged 1 commit intomainfrom
chore/as-build-fix
Mar 30, 2026
Merged

chore: remove unused gitHash function and update AS requirements due to AGP 9.1.0 upgrade#221
Manabu-GT merged 1 commit intomainfrom
chore/as-build-fix

Conversation

@Manabu-GT
Copy link
Copy Markdown
Owner

@Manabu-GT Manabu-GT commented Mar 30, 2026

Summary by CodeRabbit

  • Documentation

    • Updated minimum Android Studio version requirement to Panda 2 (2025.3.2) or later.
  • Chores

    • Removed git hash generation from the build process.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

📝 Walkthrough

Walkthrough

Updated Android Studio version requirement in documentation from Narwhal 2025.1.1 to Panda 2 2025.3.2. Removed the gitHash() function and associated build config field generation from the sample module's build script.

Changes

Cohort / File(s) Summary
Documentation
CONTRIBUTING.md
Updated prerequisite Android Studio version requirement from Narwhal (2025.1.1) to Panda 2 (2025.3.2).
Build Configuration
sample/build.gradle.kts
Removed gitHash() helper function and eliminated BuildConfig.GIT_HASH generation from android.defaultConfig.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately reflects the two main changes in the PR: removing the unused gitHash function and updating Android Studio requirements due to AGP 9.1.0 upgrade.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/as-build-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Manabu-GT Manabu-GT changed the title chore: remove unused githash function causing an issue with AS Panda … chore: remove unused githash function causing an issue with AS Panda / AGP 9.1.0 Mar 30, 2026
@Manabu-GT Manabu-GT changed the title chore: remove unused githash function causing an issue with AS Panda / AGP 9.1.0 chore: remove unused githash function causing an issue with AS Panda 2 / AGP 9.1.0 Mar 30, 2026
@Manabu-GT Manabu-GT changed the title chore: remove unused githash function causing an issue with AS Panda 2 / AGP 9.1.0 chore: remove unused gitHash function causing an issue with AS Panda 2 / AGP 9.1.0 Mar 30, 2026
@github-actions
Copy link
Copy Markdown

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@Manabu-GT Manabu-GT changed the title chore: remove unused gitHash function causing an issue with AS Panda 2 / AGP 9.1.0 chore: remove unused gitHash function and update AS requirements due to AGP 9.1.0 upgrade Mar 30, 2026
Repository owner deleted a comment from claude bot Mar 30, 2026
@Manabu-GT Manabu-GT merged commit 98b6a25 into main Mar 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant