This repository was archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Update template upload for rhevm, name database disk#8936
Merged
jawatts merged 2 commits intoManageIQ:masterfrom Jun 25, 2019
Merged
[1LP][RFR] Update template upload for rhevm, name database disk#8936jawatts merged 2 commits intoManageIQ:masterfrom
jawatts merged 2 commits intoManageIQ:masterfrom
Conversation
izapolsk
changed the title
kedark3
reviewed
Jun 11, 2019
cfme/utils/template/rhevm.py
Outdated
Contributor
There was a problem hiding this comment.
I see we are defaulting to this value, do you think it would benefit us in any way to have that as a parameter on add_disk_to_vm?
Member
Author
There was a problem hiding this comment.
Not in this case, since this is just a template upload method.
Contributor
|
LGTM, only one comment. |
kedark3
approved these changes
Jun 11, 2019
mshriver
changed the title
jawatts
approved these changes
Jun 25, 2019
mshriver
force-pushed
the
rhevm-thick-deploy-args
branch
from
eb759ee to
98bec32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on wrapanapi:
RedHatQE/wrapanapi#390