Skip to content

Precompiled lib, use webpack and update dependency versions#32

Open
scags9876 wants to merge 9 commits intoMandarinConLaBarba:masterfrom
scags9876:remove-compiled-lib
Open

Precompiled lib, use webpack and update dependency versions#32
scags9876 wants to merge 9 commits intoMandarinConLaBarba:masterfrom
scags9876:remove-compiled-lib

Conversation

@scags9876
Copy link

Some useful stuff in here, thought others might benefit from these changes.

  • using webpack instead of grunt and browserify
  • including a prepublish script to precompile transpiled code and include it in a lib directory in the package published on npm
  • upgrading dependencies to work with react 15
  • upgrade to lodash 4.x

he8us and others added 7 commits July 1, 2016 10:49
Moved from browserify and grunt to webpack
Use babel with react preset
Npm based build
- Set react dependencies to >=0.14.x so that it will accept react 15
@scags9876
Copy link
Author

Addresses:

#23
#19
#21

@jbrodriguez
Copy link

@scags9876 have you published your 'fork' to npm ?

If that's not the case, how can one use your code directly from github (since the compiled lib doesn't exist in github)

@scags9876
Copy link
Author

@jbrodriguez I have not published to npm... I'm waiting for @MandarinConLaBarba to merge this PR so he can publish.

In the meantime, i've got the following in my package.json:

"react-tree-menu": "git://github.com/scags9876/react-tree-menu.git",

It points to my master branch on my fork, which has the precompiled lib... see #31 (comment)

@scags9876 scags9876 force-pushed the remove-compiled-lib branch from a47d4d7 to 5fbf07b Compare January 12, 2018 22:35
@scags9876
Copy link
Author

this PR now includes the fix for the undefined PropType from #33

These mainly address deprecation warnings given with react 15.

 - Remove soon to be deprecated React.propTypes in favor of the PropTypes package.  See https://fb.me/prop-types-docs
 - Remove soon to be deprecated React.createClass in favor of the creatReactClass package. See https://fb.me/react-create-class
 - Fix bug with undefined propType warning
@scags9876 scags9876 force-pushed the remove-compiled-lib branch from 5fbf07b to a1e3b3d Compare January 12, 2018 23:26
@xitarps
Copy link

xitarps commented Nov 26, 2021

@jbrodriguez I have not published to npm... I'm waiting for @MandarinConLaBarba to merge this PR so he can publish.

In the meantime, i've got the following in my package.json:

"react-tree-menu": "git://github.com/scags9876/react-tree-menu.git",

It points to my master branch on my fork, which has the precompiled lib... see #31 (comment)

Thanks!! helped me a lot!! /o/
Mandou muito! (BR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants