Graphical tracker#220
Open
lafitteque wants to merge 4 commits into
Open
Conversation
Removed most prints as well
When the files are not found or empty, don't build a new tab
Contributor
|
Please share a working example. It's very hard to test the code without one. |
Author
|
Of course, here is my own example (the logic is not complete but it should not matter for testing). I just put the data folder as it's the only addition needed to test the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the possiblility to put two new jsons in the data folder :
Each json adds a corresponding tab showing a visual tracker for tab_items and a visual location sender for tab_locations.
The json format accepted is the same as the following examples :
1. tab_items :
or
Items are tracked by their name. So if there is no name, it serves only as a visual help (text / image)
2. tab_locations : (pretty similar)
The tabe will create buttons based on these descriptions. If name is not given, it will only add label and image (visual help).
Result : When the corresponding json files are added, two new tabs appear. One showing the items received, one showing the buttons to send locations.
**Why this should be added to the project : ** The current button lists are not immersive and can be hard to navigate or even to design when referring to things with non obvious names. In addition, graphical tabs would be a perfect way to help manual makers design their client as they will.
Progress to be done :
EDIT :
I forgot to mention there is no example for the the current example.
I can send you my current example I'm working with.
Also, I made no documentation for making the jsons.
EDIT 2 :
Data folder to test the PR : PRdata.zip