Add support for assigning a list of items to filler_item_name#223
Open
Seatori wants to merge 5 commits into
Open
Add support for assigning a list of items to filler_item_name#223Seatori wants to merge 5 commits into
Seatori wants to merge 5 commits into
Conversation
silasary
requested changes
Jul 7, 2026
silasary
left a comment
silasary
left a comment
Contributor
There was a problem hiding this comment.
Mostly good, just a few minor things
Co-authored-by: Katelyn Gigante <clockwork.singularity@gmail.com>
silasary
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
filler_item_name(andhook_get_filler_item_name) to allow them to be provided a list of strings instead of the standard single string, in addition to maintaining support for using a single string.When given a list of strings,
get_filler_item_namepicks an item at random each time it is prompted to make a filler item.I tested this by generating worlds with unique single filler names, unique lists of filler names, and filler names overlapping with items that had been assigned in
items.jsonin every combination I could think of.